You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/12/07 18:51:46 UTC
[GitHub] incubator-beam pull request #1536: [BEAM-664] Revise WindowedWordCount examp...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1536
[BEAM-664] Revise WindowedWordCount example to be more independent of runner and execution style
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This removes the use of BigQuery from the WindowedWordCount example, replacing it with a somewhat hacky file-based write of the output, using the window as the idempotency key. In order to port the test and to benefit from recent improvements in `FileBasedCheckSumMatcher`, I've factored out the resiliency code from that into an internal-only minimal `ShardedFile` class with just enough API surface to write these tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam WindowedWordCount
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1536
----
commit bac7b192c9fefdf536e324f1fde73bac2cd903fa
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-04T03:44:45Z
Add IntervalWindow coder to the standard registry
commit aa09449379dfaedbdfb0b73bae85ffd334b838b1
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-03T21:37:26Z
Revise WindowedWordCount for runner and execution mode portability
commit 357732efb866e4a24d76a9aaafa10e6bc964fe7e
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-08T06:06:00Z
Check the onSuccessMatcher in DirectRunner if isBlockOnRun is set
commit 76d19716829cb98c4f0d4b34244fde8866b6d6a9
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-05T22:32:12Z
Factor out ShardedFile from FileChecksumMatcher
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1536: [BEAM-1135] Revise WindowedWordCount exam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1536
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---