You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2011/08/09 13:08:59 UTC
Review Request: HIVE-2344. filter is removed due to regression of HIVE-1538
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1404/
-----------------------------------------------------------
Review request for hive, John Sichi and Yongqiang He.
Summary
-------
Any filter on 'udf selected as column alias in select' will be pushed down through the select operator, which it should not. Patch addresses this by walking through the udf expression again.
This addresses bug HIVE-2344.
https://issues.apache.org/jira/browse/HIVE-2344
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java 1153812
trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153812
trunk/ql/src/test/queries/clientpositive/ppd_udf_col.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/ppd_udf_col.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1404/diff
Testing
-------
Thanks,
Amareshwari
Re: Review Request: HIVE-2344. filter is removed due to regression of
HIVE-1538
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1404/
-----------------------------------------------------------
(Updated 2011-08-10 17:06:46.444966)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
The filter on 'udf selected as column alias in select' is no more pushed beyond the select.
Summary (updated)
-------
Any filter on 'udf selected as column alias in select' will be pushed down through the select operator, which it should not.
This addresses bug HIVE-2344.
https://issues.apache.org/jira/browse/HIVE-2344
Diffs (updated)
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java 1156069
trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1156069
trunk/ql/src/test/queries/clientpositive/ppd_udf_col.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/ppd_udf_col.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1404/diff
Testing (updated)
-------
All tests pass with the patch.
Thanks,
Amareshwari