[jira] [Commented] (TINKERPOP-2611) Prevent property(id,null) and addV(null)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439402#comment-17439402 ] 

ASF GitHub Bot commented on TINKERPOP-2611:
-------------------------------------------

spmallette opened a new pull request #1492:
URL: https://github.com/apache/tinkerpop/pull/1492


   https://issues.apache.org/jira/browse/TINKERPOP-2611
   
   This was allowed in 3.5.x when nulls were added but it could lead to confusing situations. It's a breaking change so users will need to switch to take a bit of care when calling these methods.
   
   Builds with `mvn clean install` - VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prevent property(id,null) and addV(null)
> ----------------------------------------
>
>                 Key: TINKERPOP-2611
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2611
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.5.1
>            Reporter: Stephen Mallette
>            Priority: Minor
>              Labels: breaking
>
> for {{g.addV().property(id,null)}} isn't quite the same as the {{String}} key version because the {{id}} can't be {{null}} and it can't behave like a removal for graphs that don't support null values. allow this might also create hard to figure out bugs where a variable for the {{id}} gets set to {{null}} accidentally and random data gets created rather than getting an error. There is a similar argument to be made for {{addV(null)}}.
> at this time, there is a test that enforces this behavior so to remove that changes behavior which means we probably need to save this for a breaking change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)