You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/28 08:55:00 UTC

[GitHub] [kafka] saddays opened a new pull request #10781: MINOR: Reduce duplicate authentication check

saddays opened a new pull request #10781:
URL: https://github.com/apache/kafka/pull/10781


   *More detailed description of your change,
   
   Reduce repeat authentication check for same broker.
   
   *Summary of testing strategy (including rationale)
   
   The requests belong to same broker, it's unnecessary to check every request , although the check is cheap.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] saddays commented on pull request #10781: MINOR: Reduce duplicate authentication check

Posted by GitBox <gi...@apache.org>.
saddays commented on pull request #10781:
URL: https://github.com/apache/kafka/pull/10781#issuecomment-853546556


   > I don't think this is correct, since we are verifying the node authentication status after request being disconnected. Do you recall the reasoning for calling this API like this? @hachikuji
   
   
   Thanks for your review.
   
   The node authentication status is updated by **NetworkClient.processDisconnection** , so the node authentication status is **known** after disconnecting.    **NetworkClient.authenticationException**  just read the status of the node, not realy connect it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] saddays commented on pull request #10781: MINOR: Reduce duplicate authentication check

Posted by GitBox <gi...@apache.org>.
saddays commented on pull request #10781:
URL: https://github.com/apache/kafka/pull/10781#issuecomment-853546556


   > I don't think this is correct, since we are verifying the node authentication status after request being disconnected. Do you recall the reasoning for calling this API like this? @hachikuji
   
   
   Thanks for your review.
   
   The node authentication status is updated by **NetworkClient.processDisconnection** , so the node authentication status is **known** after disconnecting.    **NetworkClient.authenticationException**  just read the status of the node, not realy connect it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] Loyilee closed pull request #10781: MINOR: Reduce duplicate authentication check

Posted by GitBox <gi...@apache.org>.
Loyilee closed pull request #10781:
URL: https://github.com/apache/kafka/pull/10781


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org