You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gr...@apache.org on 2017/12/11 18:56:52 UTC
mesos git commit: Instructed frameworks to avoid setting the offer
operation 'id' field.
Repository: mesos
Updated Branches:
refs/heads/master d7c14eab2 -> 83f81b7b2
Instructed frameworks to avoid setting the offer operation 'id' field.
The framework API side of offer operation feedback has not yet been
implemented, so frameworks should currently avoid setting this field.
See MESOS-8054.
Review: https://reviews.apache.org/r/64457/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/83f81b7b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/83f81b7b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/83f81b7b
Branch: refs/heads/master
Commit: 83f81b7b21621af1b902ef0c643fbc35c345b51f
Parents: d7c14ea
Author: Greg Mann <gr...@mesosphere.io>
Authored: Mon Dec 11 09:43:34 2017 -0800
Committer: Greg Mann <gr...@gmail.com>
Committed: Mon Dec 11 09:43:34 2017 -0800
----------------------------------------------------------------------
include/mesos/mesos.proto | 7 ++++++-
include/mesos/v1/mesos.proto | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/83f81b7b/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 839ddb1..0ce2598 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -1973,7 +1973,12 @@ message Offer {
}
optional Type type = 1;
- optional OfferOperationID id = 12;
+
+ // NOTE: The `id` field will allow frameworks to indicate that they wish to
+ // receive feedback about an offer operation. Since this feature is not yet
+ // implemented, the `id` field should NOT be set at present. See MESOS-8054.
+ optional OfferOperationID id = 12; // Experimental.
+
optional Launch launch = 2;
optional LaunchGroup launch_group = 7;
optional Reserve reserve = 3;
http://git-wip-us.apache.org/repos/asf/mesos/blob/83f81b7b/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 0ea17a8..10ce949 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -1954,7 +1954,12 @@ message Offer {
}
optional Type type = 1;
- optional OfferOperationID id = 12;
+
+ // NOTE: The `id` field will allow frameworks to indicate that they wish to
+ // receive feedback about an offer operation. Since this feature is not yet
+ // implemented, the `id` field should NOT be set at present. See MESOS-8054.
+ optional OfferOperationID id = 12; // Experimental.
+
optional Launch launch = 2;
optional LaunchGroup launch_group = 7;
optional Reserve reserve = 3;