You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/13 08:28:38 UTC
[jira] [Commented] (CB-8667) Issues with callback results where
status == NO_RESULT | 0
[ https://issues.apache.org/jira/browse/CB-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360046#comment-14360046 ]
ASF GitHub Bot commented on CB-8667:
------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-js/pull/103
[CB-8667][Windows]Handle case where checking for NORESULT returns falsy ...
...because NORESULT == 0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-js CB-8667
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit 214f9d3353736a3371e78923c9802f7c04f9c854
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-03-13T07:26:38Z
[CB-8667][Windows]Handle case where checking for NORESULT returns falsy because NORESULT == 0
----
> Issues with callback results where status == NO_RESULT | 0
> ----------------------------------------------------------
>
> Key: CB-8667
> URL: https://issues.apache.org/jira/browse/CB-8667
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Jesse MacFadyen
> Assignee: Jesse MacFadyen
>
> Due to the enumeration of cordova.callbackStatus (NO_RESULT = 0 and OK = 1), the logic used for defaulting to cordova.callbackStatus.OK will always default to cordova.callbackStatus.OK when the callbackStatus is set to cordova.callbackStatus.NO_RESULT.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org