You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/05 01:40:29 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4774:
Refactor virtualColumn to extraColumn
codecov-io edited a comment on issue #4774: Refactor virtualColumn to extraColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-548993487
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=h1) Report
> Merging [#4774](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/363d47fb502cd2c18976676944366cf6830feac5?src=pr&el=desc) will **increase** coverage by `19.76%`.
> The diff coverage is `84.31%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4774 +/- ##
=============================================
+ Coverage 38.13% 57.89% +19.76%
- Complexity 0 4 +4
=============================================
Files 1209 1207 -2
Lines 64974 64975 +1
Branches 9465 9470 +5
=============================================
+ Hits 24776 37619 +12843
+ Misses 37930 24488 -13442
- Partials 2268 2868 +600
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ment/extracolumn/IntSingleValueDataFileReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL0ludFNpbmdsZVZhbHVlRGF0YUZpbGVSZWFkZXIuamF2YQ==) | `77.77% <ø> (ø)` | `0 <0> (?)` | |
| [...segment/extracolumn/ExtraColumnIndexContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL0V4dHJhQ29sdW1uSW5kZXhDb250YWluZXIuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (?)` | |
| [...t/core/segment/extracolumn/ExtraColumnContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL0V4dHJhQ29sdW1uQ29udGV4dC5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `92.45% <100%> (+2.25%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/segment/extracolumn/BaseExtraColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL0Jhc2VFeHRyYUNvbHVtblByb3ZpZGVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...t/extracolumn/SingleStringExtraColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL1NpbmdsZVN0cmluZ0V4dHJhQ29sdW1uUHJvdmlkZXIuamF2YQ==) | `51.42% <100%> (ø)` | `0 <0> (?)` | |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <100%> (-1.54%)` | `0 <0> (ø)` | |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `83.53% <100%> (+16.96%)` | `0 <0> (ø)` | :arrow_down: |
| [...egment/extracolumn/DocIdVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2V4dHJhY29sdW1uL0RvY0lkVmlydHVhbENvbHVtblByb3ZpZGVyLmphdmE=) | `71.79% <100%> (ø)` | `0 <0> (?)` | |
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `32.07% <50%> (-0.62%)` | `0 <0> (ø)` | |
| ... and [604 more](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=footer). Last update [363d47f...47542fe](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org