You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/15 22:13:44 UTC
[GitHub] [flink] zentol opened a new pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
zentol opened a new pull request #14945:
URL: https://github.com/apache/flink/pull/14945
The scala quickstarts now use the same jvm version as the `-target` as the main project; this ensures that the experience for scala users is identical to what we see when we write tests or use the APIs ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
}, {
"hash" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbc24872255ef31a1482da7ec9c9e64385f0aa9d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660)
* 8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14945:
URL: https://github.com/apache/flink/pull/14945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14945:
URL: https://github.com/apache/flink/pull/14945#discussion_r603063590
##########
File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
+ <target.java.version>@target.java.version@</target.java.version>
Review comment:
Those are good suggestions and will help us down the line once we default to Java 11.
Currently it still should've worked though; because the goal was to just get the scala compiler to work with java 8 instead of 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358)
* dbc24872255ef31a1482da7ec9c9e64385f0aa9d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779471792
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef (Mon Feb 15 22:16:54 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
}, {
"hash" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15801",
"triggerID" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbc24872255ef31a1482da7ec9c9e64385f0aa9d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660)
* 8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779471792
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195 (Sat Aug 28 11:10:49 UTC 2021)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358)
* dbc24872255ef31a1482da7ec9c9e64385f0aa9d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
}, {
"hash" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15801",
"triggerID" : "8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8889ca12f11ecb1b5452ed2db2b9f0bdb69ec195 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14945:
URL: https://github.com/apache/flink/pull/14945#discussion_r602324877
##########
File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
+ <target.java.version>@target.java.version@</target.java.version>
Review comment:
Shouldn't we also update `maven-compiler-plugin` in this `pom.xml` to use `${target.java.version}`?
##########
File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
+ <target.java.version>@target.java.version@</target.java.version>
Review comment:
Maybe also update this field in the `flink-quickstart-java` module. I think there it is fixed to `1.8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
}, {
"hash" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660",
"triggerID" : "dbc24872255ef31a1482da7ec9c9e64385f0aa9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbc24872255ef31a1482da7ec9c9e64385f0aa9d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14945: [FLINK-21252][quickstarts][scala] Forward target java version
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14945:
URL: https://github.com/apache/flink/pull/14945#issuecomment-779476279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358",
"triggerID" : "f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2a22dee2c998b0fe470e9c41ee62d3f6cce77ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org