You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by lyj <no...@github.com.INVALID> on 2021/02/28 12:39:24 UTC
[apache/incubator-teaclave] Rmmove unnecessary line in CMakeLists.txt
(#489)
## Description
I'm not sure it's right, but I successfully compile it without these lines on Ubuntu20.04.2.
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [ ] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-teaclave/pull/489
-- Commit Summary --
* Rmmove unnecessary line in CMakeLists.txt
-- File Changes --
M CMakeLists.txt (3)
-- Patch Links --
https://github.com/apache/incubator-teaclave/pull/489.patch
https://github.com/apache/incubator-teaclave/pull/489.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/489
Re: [apache/incubator-teaclave] Rmmove unnecessary line in
CMakeLists.txt (#489)
Posted by Mingshen Sun <no...@github.com.INVALID>.
Thanks for your contribution.
The `INTEL_SGX_SDK_FOUND` variable is set by checking if the `libsgx_urts` library is installed. Instead of simply deleting this check, can you find out the root cause of not compiling on Ubuntu 20.04.2? Thanks.
```
pkg_check_modules(INTEL_SGX_SDK QUIET libsgx_urts=2.9.101.2)
if(NOT INTEL_SGX_SDK_FOUND)
message(FATAL_ERROR "Intel SGX SDK (version 2.9.1) is not found or version not matched.")
endif()
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/489#issuecomment-787537243
Re: [apache/incubator-teaclave] Rmmove unnecessary line in
CMakeLists.txt (#489)
Posted by lyj <no...@github.com.INVALID>.
Closed #489.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/489#event-4394236091