You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "zvikara (via GitHub)" <gi...@apache.org> on 2023/03/17 00:57:45 UTC
[GitHub] [incubator-baremaps] zvikara opened a new pull request, #601: osm data config
zvikara opened a new pull request, #601:
URL: https://github.com/apache/incubator-baremaps/pull/601
- git ignore .vscode and basemap cache
- move data.osm.pbf download url to config.js and ignore local config files in basemap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis commented on pull request #601: osm data config
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #601:
URL: https://github.com/apache/incubator-baremaps/pull/601#issuecomment-1484065113
I think these three commits were also referenced in #599 that just got merged. Let me know if I missed something. Thank you for the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis commented on a diff in pull request #601: osm data config
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #601:
URL: https://github.com/apache/incubator-baremaps/pull/601#discussion_r1140192765
##########
RELEASE.md:
##########
@@ -0,0 +1,123 @@
+# Release instructions
+
+In order to release a new version of Apache Baremaps, follow these steps:
+
+- [ ] Notify the mailing list and ask everyone to pause commits on the main branch
+- [ ] Create a new issue on GitHub with the title "Release Baremaps <version>"
+- [ ] Create a new branch for the release (e.g. `release-<version>`)
+
+```bash
+git checkout -b release-<version>
+git push --set-upstream origin release-<version>
+```
+
+- [ ] Set the release version and commit the changes:
+
+```bash
+mvn versions:set -DnewVersion=<version>
+git commit -a -m "Release Baremaps <version>"
+```
+
+- [ ] Tag the last commit with the release candidate version:
+
+```bash
+git tag v<version>-rc<number>
+```
+
+- [ ] Push the tag to the remote repository:
+
+```bash
+git push origin v<version>-rc<number>
+```
+
+- [ ] Generate the release notes for this tag on GitHub.
+- [ ] Generate the artifacts:
+
+```bash
+./scripts/generate-artifacts.sh
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/dev/incubator/baremaps/ baremaps-dev
+mkdir baremaps-dev/<version>-rc<number>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-dev/<version>-rc<number>/.
+svn commit -m "Baremaps <version>-rc<number>"
+```
+
+- [ ] Ask the community to vote for the release candidate.
+- [ ] If the release candidate is not approved by the community, commit the necessary changes, clean the git history, and go back to step 5.
+- [ ] If the release candidate is approved by the community, tag the release commit with the release version:
+
+```bash
+git tag -a v[version]
+git push origin v[version]
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/release/incubator/baremaps/ baremaps-release
+mkdir baremaps-release/<version>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-release/<version>/.
Review Comment:
The source release is built with the maven assembly plugin. Here is were the missing files should be added:
https://github.com/apache/incubator-baremaps/blob/main/baremaps-cli/src/assembly/src.xml
I think we could also improve it by excluding the target directories by adding an `<exclude></exclude>` element:
https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] swerky commented on a diff in pull request #601: osm data config
Posted by "swerky (via GitHub)" <gi...@apache.org>.
swerky commented on code in PR #601:
URL: https://github.com/apache/incubator-baremaps/pull/601#discussion_r1140117641
##########
RELEASE.md:
##########
@@ -0,0 +1,123 @@
+# Release instructions
+
+In order to release a new version of Apache Baremaps, follow these steps:
+
+- [ ] Notify the mailing list and ask everyone to pause commits on the main branch
+- [ ] Create a new issue on GitHub with the title "Release Baremaps <version>"
+- [ ] Create a new branch for the release (e.g. `release-<version>`)
+
+```bash
+git checkout -b release-<version>
+git push --set-upstream origin release-<version>
+```
+
+- [ ] Set the release version and commit the changes:
+
+```bash
+mvn versions:set -DnewVersion=<version>
+git commit -a -m "Release Baremaps <version>"
+```
+
+- [ ] Tag the last commit with the release candidate version:
+
+```bash
+git tag v<version>-rc<number>
+```
+
+- [ ] Push the tag to the remote repository:
+
+```bash
+git push origin v<version>-rc<number>
+```
+
+- [ ] Generate the release notes for this tag on GitHub.
+- [ ] Generate the artifacts:
+
+```bash
+./scripts/generate-artifacts.sh
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/dev/incubator/baremaps/ baremaps-dev
+mkdir baremaps-dev/<version>-rc<number>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-dev/<version>-rc<number>/.
+svn commit -m "Baremaps <version>-rc<number>"
+```
+
+- [ ] Ask the community to vote for the release candidate.
+- [ ] If the release candidate is not approved by the community, commit the necessary changes, clean the git history, and go back to step 5.
+- [ ] If the release candidate is approved by the community, tag the release commit with the release version:
+
+```bash
+git tag -a v[version]
+git push origin v[version]
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/release/incubator/baremaps/ baremaps-release
+mkdir baremaps-release/<version>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-release/<version>/.
Review Comment:
@bchapuis is the documentation here missing information about how to add the files that Julien highlight missing in the release ?
Cf: #604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis commented on a diff in pull request #601: osm data config
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #601:
URL: https://github.com/apache/incubator-baremaps/pull/601#discussion_r1140192765
##########
RELEASE.md:
##########
@@ -0,0 +1,123 @@
+# Release instructions
+
+In order to release a new version of Apache Baremaps, follow these steps:
+
+- [ ] Notify the mailing list and ask everyone to pause commits on the main branch
+- [ ] Create a new issue on GitHub with the title "Release Baremaps <version>"
+- [ ] Create a new branch for the release (e.g. `release-<version>`)
+
+```bash
+git checkout -b release-<version>
+git push --set-upstream origin release-<version>
+```
+
+- [ ] Set the release version and commit the changes:
+
+```bash
+mvn versions:set -DnewVersion=<version>
+git commit -a -m "Release Baremaps <version>"
+```
+
+- [ ] Tag the last commit with the release candidate version:
+
+```bash
+git tag v<version>-rc<number>
+```
+
+- [ ] Push the tag to the remote repository:
+
+```bash
+git push origin v<version>-rc<number>
+```
+
+- [ ] Generate the release notes for this tag on GitHub.
+- [ ] Generate the artifacts:
+
+```bash
+./scripts/generate-artifacts.sh
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/dev/incubator/baremaps/ baremaps-dev
+mkdir baremaps-dev/<version>-rc<number>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-dev/<version>-rc<number>/.
+svn commit -m "Baremaps <version>-rc<number>"
+```
+
+- [ ] Ask the community to vote for the release candidate.
+- [ ] If the release candidate is not approved by the community, commit the necessary changes, clean the git history, and go back to step 5.
+- [ ] If the release candidate is approved by the community, tag the release commit with the release version:
+
+```bash
+git tag -a v[version]
+git push origin v[version]
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/release/incubator/baremaps/ baremaps-release
+mkdir baremaps-release/<version>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-release/<version>/.
Review Comment:
The source release is built with the maven assembly plugin. Here is were the missing files should be added:
https://github.com/apache/incubator-baremaps/blob/main/baremaps-cli/src/assembly/src.xml
I think we could also improve it by excluding the target directories with `<exclude />`:
https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis commented on a diff in pull request #601: osm data config
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #601:
URL: https://github.com/apache/incubator-baremaps/pull/601#discussion_r1140192765
##########
RELEASE.md:
##########
@@ -0,0 +1,123 @@
+# Release instructions
+
+In order to release a new version of Apache Baremaps, follow these steps:
+
+- [ ] Notify the mailing list and ask everyone to pause commits on the main branch
+- [ ] Create a new issue on GitHub with the title "Release Baremaps <version>"
+- [ ] Create a new branch for the release (e.g. `release-<version>`)
+
+```bash
+git checkout -b release-<version>
+git push --set-upstream origin release-<version>
+```
+
+- [ ] Set the release version and commit the changes:
+
+```bash
+mvn versions:set -DnewVersion=<version>
+git commit -a -m "Release Baremaps <version>"
+```
+
+- [ ] Tag the last commit with the release candidate version:
+
+```bash
+git tag v<version>-rc<number>
+```
+
+- [ ] Push the tag to the remote repository:
+
+```bash
+git push origin v<version>-rc<number>
+```
+
+- [ ] Generate the release notes for this tag on GitHub.
+- [ ] Generate the artifacts:
+
+```bash
+./scripts/generate-artifacts.sh
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/dev/incubator/baremaps/ baremaps-dev
+mkdir baremaps-dev/<version>-rc<number>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-dev/<version>-rc<number>/.
+svn commit -m "Baremaps <version>-rc<number>"
+```
+
+- [ ] Ask the community to vote for the release candidate.
+- [ ] If the release candidate is not approved by the community, commit the necessary changes, clean the git history, and go back to step 5.
+- [ ] If the release candidate is approved by the community, tag the release commit with the release version:
+
+```bash
+git tag -a v[version]
+git push origin v[version]
+```
+
+- [ ] Publish the artifacts:
+
+```bash
+svn co https://dist.apache.org/repos/dist/release/incubator/baremaps/ baremaps-release
+mkdir baremaps-release/<version>
+cp ./baremaps-cli/target/baremaps-<version>-incubating-* baremaps-release/<version>/.
Review Comment:
The source release is built with the maven assembly plugin. Here is were the missing files should be added:
https://github.com/apache/incubator-baremaps/blob/main/baremaps-cli/src/assembly/src.xml
I think we could also improve it by excluding the target directories by adding an `<exclude></exclude>` element:
https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html
We should probably continue this discussion in #597.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis closed pull request #601: osm data config
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis closed pull request #601: osm data config
URL: https://github.com/apache/incubator-baremaps/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org