You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/08/24 21:18:13 UTC

[GitHub] [lucenenet] NightOwl888 opened a new pull request #328: Temporary thread safety fix for ICUTokenizer/Locking patches for AttributeSource

NightOwl888 opened a new pull request #328:
URL: https://github.com/apache/lucenenet/pull/328


   This patch fixes thread safety with `ICUTokenizer` and makes it pass the `TestRandomStrings` and `TestRandomHugeStrings` of both `TestICUTokenizer` and `TestICUTokenizerCJK` test classes (see #269). This serves as proof that thread safety is broken in ICU4N's BreakIterator and the patch can be reverted once the thread safety issues have been addressed in ICU4N.
   
   The `ThaiTokenizer` is also patched slightly better here, but it still occasionally fails the `TestRandomStrings` and `TestRandomHugeStrings` tests (see #269).
   
   This PR also contains some performance improvements for `AttributeSource` that make the tests less likely to run slow due to threading contention issues or unnecessary dictionary lookups.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [lucenenet] NightOwl888 merged pull request #328: Temporary thread safety fix for ICUTokenizer/Locking patches for AttributeSource

Posted by GitBox <gi...@apache.org>.
NightOwl888 merged pull request #328:
URL: https://github.com/apache/lucenenet/pull/328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org