You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Hyong Kim (JIRA)" <ji...@apache.org> on 2013/10/04 00:32:44 UTC
[jira] [Updated] (CB-4995) iOS application crashes when
InAppBrowser is opened and quickly closed
[ https://issues.apache.org/jira/browse/CB-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyong Kim updated CB-4995:
--------------------------
Description:
I personally experienced the issue with 2.8.15, but it appears others are seeing the same problem even on version 3. Just now, I quickly took a look at the latest version 3 source code, and it is likely that the issue is still around. That is, I had identified the cause of the crash and we fixed it in our app.
The issue is presented when a user rapidly opens and closes InAppBrowser while using Cordova iOS application because (referring to the latest CDVInAppBrowser.m as of 10/3/2013 with commit hash of a001cffc30cf94cb406128f7b68d143e2cd62114) self.inAppBrowserViewController (line: 332) is nil if 'browserExit' (line: 353) is called before 'webViewDidFinishLoad' (line: 328) is invoked.
We put our own patch around line 332 as below, and didn't experience the crash any more with 2.8.15
{code:title=CDVInAppBrowser.m excerpt|borderStyle=solid}
if (self.inAppBrowserViewController != nil) {
url = [self.inAppBrowserViewController.currentURL absoluteString];
} else {
url = @"";
}
{code}
was:
I personally experienced the issue with 2.8.15, but it appears others are seeing the same problem even on version 3. Just now, I quickly took a look at the latest version 3 source code, and it is likely that the issue is still around. That is, I had identified the cause of the crash and we fixed it in our app.
The issue is presented when a user rapidly opens and closes InAppBrowser while using Cordova iOS application because (referring to the latest CDVInAppBrowser.m as of 10/3/2013 with commit hash of a001cffc30cf94cb406128f7b68d143e2cd62114) self.inAppBrowserViewController (line: 332) is nil if 'browserExit' (line: 353) is called before 'webViewDidFinishLoad' (line: 328) is invoked.
We put our own patch around line 332 as below, and didn't experience the crash any more with 2.8.15
if (self.inAppBrowserViewController != nil) {
url = [self.inAppBrowserViewController.currentURL absoluteString];
} else {
url = @"";
}
> iOS application crashes when InAppBrowser is opened and quickly closed
> ----------------------------------------------------------------------
>
> Key: CB-4995
> URL: https://issues.apache.org/jira/browse/CB-4995
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
> Affects Versions: 2.7.0, 2.8.0, 2.9.0, 3.0.0
> Environment: iOS
> Reporter: Hyong Kim
>
> I personally experienced the issue with 2.8.15, but it appears others are seeing the same problem even on version 3. Just now, I quickly took a look at the latest version 3 source code, and it is likely that the issue is still around. That is, I had identified the cause of the crash and we fixed it in our app.
> The issue is presented when a user rapidly opens and closes InAppBrowser while using Cordova iOS application because (referring to the latest CDVInAppBrowser.m as of 10/3/2013 with commit hash of a001cffc30cf94cb406128f7b68d143e2cd62114) self.inAppBrowserViewController (line: 332) is nil if 'browserExit' (line: 353) is called before 'webViewDidFinishLoad' (line: 328) is invoked.
> We put our own patch around line 332 as below, and didn't experience the crash any more with 2.8.15
> {code:title=CDVInAppBrowser.m excerpt|borderStyle=solid}
> if (self.inAppBrowserViewController != nil) {
> url = [self.inAppBrowserViewController.currentURL absoluteString];
> } else {
> url = @"";
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)