You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/01/31 15:55:46 UTC

[GitHub] ihuzenko edited a comment on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

ihuzenko edited a comment on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query
URL: https://github.com/apache/drill/pull/1608#issuecomment-459396389
 
 
   Hello @kkhatua . Thanks for fixing issues, I've checked changes and added review comments. Also I'd like to suggest remember user's choice and don't reset autoLimit checkbox and value after query submission. I think you could try [Window.sessionStorage](https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage) for this.  Also please squash commits into one with name ```DRILL-6960: Auto Limit Wrapping should not apply to non-select query``` and description of changes below, like [here](https://github.com/apache/drill/pull/1631/commits/48f60f9a923222b4f8e42808085844f8fbf0be64)
   
   cc: @vdiravka 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services