[GitHub] [tinkerpop] spmallette commented on pull request #1355: TINKERPOP-2445 Remove unnecessary initialization of serializers

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1355:
URL: https://github.com/apache/tinkerpop/pull/1355#issuecomment-724009038


   I think that the value of the speed improvement here is worth the removal and the possible breaking change. The scope of the "break" itself seems fairly narrow and isolated - this will not affect a lot of users (if any). If I want to take a breaking change like this within patch versions I usually just email the dev list with a DISCUSS thread and explain the reasoning/scope for the breaking change (I sometimes even email the user list if i feel it is of effect to a large number of users who might want to have an objection but i don't think that's necessary for this change). I then end the dev list post with a statement of a "72 hour lazy consensus in effect" and then link the DISCUSS thread in the JIRA.
   
   I don't think this change needs Upgrade Documentation, but a CHANGELOG entry would be good.
   
   Note that these initializations have already been removed on `master` iirc.
   
   Assuming all that is in place, then VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org