You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Edward Zheng <ed...@ringcentral.com.INVALID> on 2022/09/07 08:21:47 UTC

Please help code review

Hi guys,

I create a pull request several days ago.https://github.com/apache/mina-sshd/pull/242. I’m not sure if it’s a bugfix or my usage is wrong, could someone help review and give me some suggestions?

Thanks. 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

Re: Please help code review

Posted by Thomas Wolf <t....@gmail.com>.
On 08.09.22 13:11 , Jonathan Valliere wrote:
> I don’t know how to connect my personal account to my Apache permissions
> for Apache repos.

IIRC all I had to do was enter my GitHub account name in the Apache 
account info at https://id.apache.org/ . It may take a few hours to take 
effect.

See https://infra.apache.org/apache-github.html .

Cheers,

   Thomas



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

Re: Please help code review

Posted by Jonathan Valliere <jo...@apache.org>.
I don’t know how to connect my personal account to my Apache permissions
for Apache repos.

On Thu, Sep 8, 2022 at 3:25 AM Emmanuel Lécharny <el...@gmail.com>
wrote:

> Hi Jonathan,
>
> what is the pb you are having with GH ? Can't connect? Can't access to
> the mina-sshd repo?
>
> On 2022/09/07 12:32, Jonathan Valliere wrote:
> > Emmanuel do you have a link somewhere how to fix my connection to Apache
> on
> > GitHub?
> >
> > On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng
> > <ed...@ringcentral.com.invalid> wrote:
> >
> >> Hi guys,
> >>
> >> I create a pull request several days ago.
> >> https://github.com/apache/mina-sshd/pull/242. I’m not sure if it’s a
> >> bugfix or my usage is wrong, could someone help review and give me some
> >> suggestions?
> >>
> >> Thanks.
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
> >> For additional commands, e-mail: dev-help@mina.apache.org
> >>
> >
>
> --
> *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
> T. +33 (0)4 89 97 36 50
> P. +33 (0)6 08 33 32 61
> emmanuel.lecharny@busit.com https://www.busit.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
> For additional commands, e-mail: dev-help@mina.apache.org
>
>

Re: Please help code review

Posted by Emmanuel Lécharny <el...@gmail.com>.
Hi Jonathan,

what is the pb you are having with GH ? Can't connect? Can't access to 
the mina-sshd repo?

On 2022/09/07 12:32, Jonathan Valliere wrote:
> Emmanuel do you have a link somewhere how to fix my connection to Apache on
> GitHub?
> 
> On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng
> <ed...@ringcentral.com.invalid> wrote:
> 
>> Hi guys,
>>
>> I create a pull request several days ago.
>> https://github.com/apache/mina-sshd/pull/242. I’m not sure if it’s a
>> bugfix or my usage is wrong, could someone help review and give me some
>> suggestions?
>>
>> Thanks.
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
>> For additional commands, e-mail: dev-help@mina.apache.org
>>
> 

-- 
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecharny@busit.com https://www.busit.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

Re: Please help code review

Posted by Jonathan Valliere <jo...@apache.org>.
Emmanuel do you have a link somewhere how to fix my connection to Apache on
GitHub?

On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng
<ed...@ringcentral.com.invalid> wrote:

> Hi guys,
>
> I create a pull request several days ago.
> https://github.com/apache/mina-sshd/pull/242. I’m not sure if it’s a
> bugfix or my usage is wrong, could someone help review and give me some
> suggestions?
>
> Thanks.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
> For additional commands, e-mail: dev-help@mina.apache.org
>