[jira] [Commented] (MYFACES-3716) Implement h:inputFile

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762363#comment-13762363 ] 

Leonardo Uribe commented on MYFACES-3716:
-----------------------------------------

I have checked the patch and it still have problems:

- _MessageUtils cannot be a public class because it breaks binary compatibility.
- StateHelper cannot have public inner class, because it breaks binary compatibility. Also, put the wrapper there is not the right way to fix the problem. There is a better and cleaner alternative mentioned earlier. 
- The code that finds a parent form was already done. See _ComponentUtils.findNestingForm(component, facesContext) 
- No need of i8n for the message, because it is one intended for development time only.

After some time thinking about it, I finally have fixed the problems in a proper way. See the attached patch for details.
                
> Implement h:inputFile
> ---------------------
>
>                 Key: MYFACES-3716
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3716
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-344
>            Reporter: Leonardo Uribe
>         Attachments: inputFile.patch, MYFACES-3716-fileUpload-2.patch
>
>
> Implement h:inputFile as described in the spec

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira