[jira] [Commented] (IMPALA-4784) Remove InProcessStatestore

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923790#comment-16923790 ] 

ASF subversion and git services commented on IMPALA-4784:
---------------------------------------------------------

Commit 45cb8b2e92eeb1ab92c9e4f4e87ee9da7dca3930 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=45cb8b2 ]

Fix statestored /rpcz page

This patch fixes two issues with the statestore's /rpcz debug webui
page:

- When the statestore was refactored in IMPALA-4784 to move the
  declaration of the creation of the ThriftServer from
  statestored-main.cc into the Statestore class, the TProcessor and
  TProcessorEventHandler in StatestoredMain() were accidentally left
  even though they are no longer being used. This resulted in there
  being two RpcEventHandlers with the server name 'statstore', which
  caused the json processing logic on the /rpcz page for the statstore
  to behave incorrectly. This patch removes the extra TProcessor.
- Because the statestored does not currently have any krpc services,
  the json for its /rpcz page does not contain the 'services' field
  and refresh hits an error when trying to access it. This patch
  checks for this condition and skips updating the krpc services in
  this case.

Testing:
- Manually checked that the statestore's /rpcz page now works.

Change-Id: Iaf01c3af219e17728836c63b1e0ff10cbcb221ff
Reviewed-on: http://gerrit.cloudera.org:8080/14175
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Remove InProcessStatestore
> --------------------------
>
>                 Key: IMPALA-4784
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4784
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend, Distributed Exec
>    Affects Versions: Impala 2.9.0
>            Reporter: Henry Robinson
>            Assignee: Sailesh Mukil
>            Priority: Major
>             Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> The {{InProcessStatestore}} class is only used by the {{statestore-test}} and is likely to be obsoleted by the KRPC work. Since {{statestore-test}} doesn't provide much test coverage at all, let's remove {{InProcessStatestore}} to avoid the need to keep it up-to-date.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org