[GitHub] [tvm] cyx-6 commented on pull request #12435: [TIR] Expose Misc TIR operations to python

[GitBox <gi...@apache.org>]

cyx-6 commented on PR #12435:
URL: https://github.com/apache/tvm/pull/12435#issuecomment-1214689340

   @leandron Thanks for commenting!
   
   1.  These operations are widely uesd in current unittest sets with `T.*` currently. And the current parser directly generates `tir::Call` for these operations, refer to [here](https://github.com/apache/tvm/blob/bb513866ad70fa20eb0c37ca339d330d6a76c747/python/tvm/script/parser.py#L934). However, in the new parser, we will call these operations in `op.py`, as we have just added. The current unittest set will automatically be tests for these newly expoesd `op`s. And these newly added `op`s have passed CI with our new parser as well, which proves their correctness. So we do not add extra unittests this time. Of course, in general cases, we do have to add related unittests for these `op`s.
   2. Sure. I will update these commit messages and pay attention to it next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org