You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "werpu (via GitHub)" <gi...@apache.org> on 2024/10/22 12:47:45 UTC

[PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

werpu opened a new pull request, #769:
URL: https://github.com/apache/myfaces/pull/769

   Client side fix, adding the latest js code to the merge request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #769:
URL: https://github.com/apache/myfaces/pull/769#issuecomment-2429733428

   `myfaces.ab('j_id_c', event, 'renderAjaxOutput', '', 'ajaxOutput')`  -- maybe a future revision could look for form where the render argument (ID value) is located? 
   
   But I think this change is good enough for this test (and no users have reported this so far). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu merged PR #769:
URL: https://github.com/apache/myfaces/pull/769


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #769:
URL: https://github.com/apache/myfaces/pull/769#issuecomment-2429935299

   I will start take care of https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-4685 tomorrow, I want to wrap up the other branches with the websocket fix today!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #769:
URL: https://github.com/apache/myfaces/pull/769#issuecomment-2429207896

   @werpu can you also fix this one it looks like its a simple JS fix: https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-4685 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #769:
URL: https://github.com/apache/myfaces/pull/769#issuecomment-2429207365

   please dont forget 4.1 and 5.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4680: [myfaces]

Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #769:
URL: https://github.com/apache/myfaces/pull/769#issuecomment-2429933454

   That was not the problem if the TCK test, the problem was that the render ID was outside of any form, but given there is exactly one form in the page it was safe enough to use that one for the viewstate handling!
   It still would fail with a two form setup, but then you could use a form passthrough parameter to reference the form you want to use (a feature Mojarra probably does not have in its js implementation, but perfectly html5 compliant)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org