You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/18 02:00:20 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue, #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
ruanwenjun opened a new issue, #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
If a workflow instance/ task instance is failed, we need to query the log and find out why it failed.
Can we save the failed reason to db as metadata, and display on the ui?
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1220155831
> > @ruanwenjun Can I understand it this way, our previous logs are just the output produced by the task execution. But before execution, he may also report an error, but the user cannot view it on the front end, and can only find this error in the log file afterwards. so we should do this
>
> Yes, and the workflow may execute failed due to some other reason, we didn't display workflow log on the ui.
I suggest not just logging error messages, we should log the execution flow。eg:(start_process(success)->buildDAG (success)-> put into task queue (success)->handleCommon(failed)). this allows users to more clearly understand what went wrong in the execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1229627261
Good idea.
I found that ds workflow instance loss some message, such as stop reason, maybe it's stopped by workflow execute strategy or others, but we have to spend time searching and locating the cause from logs.
So we need this failed reason to help users locate problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1235319226
> Can you list all the states you can think of，This might give me an idea of where you'd add the logic to add these states
The state of `WorkflowExecutionStatus` enum when use. I just add the state history and state desc for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1219003957
@ruanwenjun Can I understand it this way, our previous logs are just the output produced by the task execution. But before execution, he may also report an error, but the user cannot view it on the front end, and can only find this error in the log file afterwards. so we should do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1234087603
> Here is my design of state history:
>
> * Add a new column of status description to the workflow instance list, the format is as follows:
>
> RUNNING → READY_PAUSE → PAUSE → RUNNING → STOP
>
> * Hover or click to display the specific historical status description, as follows:
>
> 
Can you list all the states you can think of，This might give me an idea of where you'd add the logic to add these states
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1218923627
I may not feel good if it just saves the error message. Because many times the error message has to be seen against the context of the program. If the context is also stored together, the larger context will cause oom，personal opinion only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1218907424
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1234039157
Here is my design of state history:
- Add a new column of status description to the workflow instance list, the format is as follows:
RUNNING → READY_PAUSE → PAUSE → RUNNING → STOP
- Hover or click to display the specific historical status description, as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1218998788
> I may not feel good if it just saves the error message. Because many times the error message has to be seen against the context of the program. If the context is also stored together, the larger context will cause oom，personal opinion only
The `error message` is not exception stack, it is defined in master/worker, e.g `dispatch failed`, `server error`, `workflow definition doesn't exist` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1220157289
> > > @ruanwenjun Can I understand it this way, our previous logs are just the output produced by the task execution. But before execution, he may also report an error, but the user cannot view it on the front end, and can only find this error in the log file afterwards. so we should do this
> >
> >
> > Yes, and the workflow may execute failed due to some other reason, we didn't display workflow log on the ui.
>
> I suggest not just logging error messages, we should log the execution flow。eg:(start_process(success)->buildDAG (success)-> put into task queue (success)->handleCommon(failed)). this allows users to more clearly understand what went wrong in the execution.
The problem is that we still need to login the master machine and query the log...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1220159931
> > > @ruanwenjun Can I understand it this way, our previous logs are just the output produced by the task execution. But before execution, he may also report an error, but the user cannot view it on the front end, and can only find this error in the log file afterwards. so we should do this
> >
> >
> > Yes, and the workflow may execute failed due to some other reason, we didn't display workflow log on the ui.
>
> I suggest not just logging error messages, we should log the execution flow。eg:(start_process(success)->buildDAG (success)-> put into task queue (success)->handleCommon(failed)). this allows users to more clearly understand what went wrong in the execution.
The `error message ` will be user friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11530: [Feature][Master] Display the workflowInstance/taskInstance failed reason
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11530:
URL: https://github.com/apache/dolphinscheduler/issues/11530#issuecomment-1220151088
> @ruanwenjun Can I understand it this way, our previous logs are just the output produced by the task execution. But before execution, he may also report an error, but the user cannot view it on the front end, and can only find this error in the log file afterwards. so we should do this
Yes, and the workflow may execute failed due to some other reason, we didn't display workflow log on the ui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org