You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/02/02 16:16:49 UTC

Review Request 30498: LENS-249: checkstyle changes for lens-server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-249
    https://issues.apache.org/jira/browse/LENS-249


Repository: lens


Description
-------

draft.


Diffs
-----

  checkstyle/src/main/resources/checkstyle.xml e519a60fca323cfaaeec6a675969a7f490330778 
  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
  lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
  lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
  lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
  lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
  lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
  lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
  lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
  lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
  lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
  lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
  lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
  lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
  lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
  lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
  lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
  lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
  lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
  lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
  lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
  lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
  lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
  lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
  lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
  lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
  lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
  lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
  lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
  lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
  lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
  lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
  lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
  lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
  lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
  lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
  lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
  lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
  lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
  lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
  lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
  lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
  lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 6c660e833b55914c0f725620148e0a800b89ddef 
  lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
  lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
  lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
  lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
  lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
  lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
  lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
  lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
  lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
  lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 

Diff: https://reviews.apache.org/r/30498/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Re: Review Request 30498: LENS-249: checkstyle changes for lens-server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/#review70742
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Feb. 3, 2015, 11:14 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30498/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:14 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-249
>     https://issues.apache.org/jira/browse/LENS-249
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> draft.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
>   lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
>   lens-server/pom.xml 048e42e3b5995acdfe975727a03a60e51ad48eaf 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
>   lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
>   lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
>   lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
>   lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
>   lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
>   lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
>   lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
>   lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
>   lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
>   lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
>   lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
>   lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
>   lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
>   lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
>   lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
>   lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
>   lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
>   lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
>   lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
>   lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
>   lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
>   lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
>   lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
>   lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
>   lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
>   lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
>   lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
>   lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
>   lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
>   lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
>   lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
>   lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
>   lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
>   lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
>   lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
>   lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
>   lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
>   lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
>   lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
>   lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
>   lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
>   lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
>   lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
>   lens-server/src/test/java/org/apache/lens/server/common/LenServerTestException.java f2abfd9d3f2859fff04df1b609ae36b56ad3d109 
>   lens-server/src/test/java/org/apache/lens/server/common/LensServerTestFileUtils.java 5962ebb619ee1c1aec7342f9e5de78622379e865 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
>   lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
>   lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
>   lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
>   lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 13760f75d40ac85b1eafe29e441a849bbd508011 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
>   lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
>   lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
>   lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
>   lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
>   lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
>   lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
>   lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
>   lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
>   lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 
> 
> Diff: https://reviews.apache.org/r/30498/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.170s]
> [INFO] Lens .............................................. SUCCESS [1.766s]
> [INFO] Lens API .......................................... SUCCESS [5.401s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.885s]
> [INFO] Lens Cube ......................................... SUCCESS [6:20.460s]
> [INFO] Lens DB storage ................................... SUCCESS [10.273s]
> [INFO] Lens Query Library ................................ SUCCESS [4.852s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:39.182s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [25.155s]
> [INFO] Lens Server ....................................... SUCCESS [4:16.664s]
> [INFO] Lens client ....................................... SUCCESS [19.465s]
> [INFO] Lens CLI .......................................... SUCCESS [1:43.051s]
> [INFO] Lens Examples ..................................... SUCCESS [0.787s]
> [INFO] Lens Distribution ................................. SUCCESS [4.680s]
> [INFO] Lens Client Distribution .......................... SUCCESS [6.284s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.155s]
> [INFO] Lens Regression ................................... SUCCESS [0.471s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:11.615s
> [INFO] Finished at: Tue Feb 03 06:10:42 UTC 2015
> [INFO] Final Memory: 108M/1112M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 30498: LENS-249: checkstyle changes for lens-server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 11:14 a.m.)


Review request for lens.


Bugs: LENS-249
    https://issues.apache.org/jira/browse/LENS-249


Repository: lens


Description
-------

draft.


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
  lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
  lens-server/pom.xml 048e42e3b5995acdfe975727a03a60e51ad48eaf 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
  lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
  lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
  lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
  lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
  lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
  lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
  lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
  lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
  lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
  lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
  lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
  lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
  lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
  lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
  lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
  lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
  lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
  lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
  lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
  lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
  lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
  lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
  lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
  lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
  lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
  lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
  lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
  lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
  lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
  lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
  lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
  lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
  lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
  lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
  lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
  lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
  lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
  lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
  lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
  lens-server/src/test/java/org/apache/lens/server/common/LenServerTestException.java f2abfd9d3f2859fff04df1b609ae36b56ad3d109 
  lens-server/src/test/java/org/apache/lens/server/common/LensServerTestFileUtils.java 5962ebb619ee1c1aec7342f9e5de78622379e865 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
  lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 13760f75d40ac85b1eafe29e441a849bbd508011 
  lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
  lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
  lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
  lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
  lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
  lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
  lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
  lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
  lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
  lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 

Diff: https://reviews.apache.org/r/30498/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.170s]
[INFO] Lens .............................................. SUCCESS [1.766s]
[INFO] Lens API .......................................... SUCCESS [5.401s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.885s]
[INFO] Lens Cube ......................................... SUCCESS [6:20.460s]
[INFO] Lens DB storage ................................... SUCCESS [10.273s]
[INFO] Lens Query Library ................................ SUCCESS [4.852s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.182s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.155s]
[INFO] Lens Server ....................................... SUCCESS [4:16.664s]
[INFO] Lens client ....................................... SUCCESS [19.465s]
[INFO] Lens CLI .......................................... SUCCESS [1:43.051s]
[INFO] Lens Examples ..................................... SUCCESS [0.787s]
[INFO] Lens Distribution ................................. SUCCESS [4.680s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.284s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.155s]
[INFO] Lens Regression ................................... SUCCESS [0.471s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:11.615s
[INFO] Finished at: Tue Feb 03 06:10:42 UTC 2015
[INFO] Final Memory: 108M/1112M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 30498: LENS-249: checkstyle changes for lens-server

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/#review70718
-----------------------------------------------------------

Ship it!


Please distribute the new lens formatter to everyone, on which you are already working, to adhere to the checkstyle rules.

- Himanshu Gahlaut


On Feb. 3, 2015, 6:29 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30498/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 6:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-249
>     https://issues.apache.org/jira/browse/LENS-249
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> draft.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
>   lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
>   lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
>   lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
>   lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
>   lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
>   lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
>   lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
>   lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
>   lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
>   lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
>   lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
>   lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
>   lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
>   lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
>   lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
>   lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
>   lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
>   lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
>   lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
>   lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
>   lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
>   lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
>   lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
>   lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
>   lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
>   lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
>   lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
>   lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
>   lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
>   lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
>   lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
>   lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
>   lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
>   lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
>   lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
>   lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
>   lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
>   lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
>   lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
>   lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
>   lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
>   lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
>   lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
>   lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
>   lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
>   lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
>   lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
>   lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
>   lens-server/src/test/java/org/apache/lens/server/common/LenServerTestException.java f2abfd9d3f2859fff04df1b609ae36b56ad3d109 
>   lens-server/src/test/java/org/apache/lens/server/common/LensServerTestFileUtils.java 5962ebb619ee1c1aec7342f9e5de78622379e865 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
>   lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
>   lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
>   lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
>   lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 13760f75d40ac85b1eafe29e441a849bbd508011 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
>   lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
>   lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
>   lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
>   lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
>   lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
>   lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
>   lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
>   lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
>   lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
>   lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 
> 
> Diff: https://reviews.apache.org/r/30498/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.170s]
> [INFO] Lens .............................................. SUCCESS [1.766s]
> [INFO] Lens API .......................................... SUCCESS [5.401s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.885s]
> [INFO] Lens Cube ......................................... SUCCESS [6:20.460s]
> [INFO] Lens DB storage ................................... SUCCESS [10.273s]
> [INFO] Lens Query Library ................................ SUCCESS [4.852s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:39.182s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [25.155s]
> [INFO] Lens Server ....................................... SUCCESS [4:16.664s]
> [INFO] Lens client ....................................... SUCCESS [19.465s]
> [INFO] Lens CLI .......................................... SUCCESS [1:43.051s]
> [INFO] Lens Examples ..................................... SUCCESS [0.787s]
> [INFO] Lens Distribution ................................. SUCCESS [4.680s]
> [INFO] Lens Client Distribution .......................... SUCCESS [6.284s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.155s]
> [INFO] Lens Regression ................................... SUCCESS [0.471s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:11.615s
> [INFO] Finished at: Tue Feb 03 06:10:42 UTC 2015
> [INFO] Final Memory: 108M/1112M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 30498: LENS-249: checkstyle changes for lens-server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 6:29 a.m.)


Review request for lens.


Bugs: LENS-249
    https://issues.apache.org/jira/browse/LENS-249


Repository: lens


Description
-------

draft.


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
  lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
  lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
  lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
  lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
  lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
  lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
  lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
  lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
  lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
  lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
  lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
  lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
  lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
  lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
  lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
  lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
  lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
  lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
  lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
  lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
  lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
  lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
  lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
  lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
  lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
  lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
  lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
  lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
  lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
  lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
  lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
  lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
  lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
  lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
  lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
  lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
  lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
  lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
  lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
  lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
  lens-server/src/test/java/org/apache/lens/server/common/LenServerTestException.java f2abfd9d3f2859fff04df1b609ae36b56ad3d109 
  lens-server/src/test/java/org/apache/lens/server/common/LensServerTestFileUtils.java 5962ebb619ee1c1aec7342f9e5de78622379e865 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
  lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 13760f75d40ac85b1eafe29e441a849bbd508011 
  lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
  lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
  lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
  lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
  lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
  lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
  lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
  lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
  lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
  lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 

Diff: https://reviews.apache.org/r/30498/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.170s]
[INFO] Lens .............................................. SUCCESS [1.766s]
[INFO] Lens API .......................................... SUCCESS [5.401s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.885s]
[INFO] Lens Cube ......................................... SUCCESS [6:20.460s]
[INFO] Lens DB storage ................................... SUCCESS [10.273s]
[INFO] Lens Query Library ................................ SUCCESS [4.852s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.182s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.155s]
[INFO] Lens Server ....................................... SUCCESS [4:16.664s]
[INFO] Lens client ....................................... SUCCESS [19.465s]
[INFO] Lens CLI .......................................... SUCCESS [1:43.051s]
[INFO] Lens Examples ..................................... SUCCESS [0.787s]
[INFO] Lens Distribution ................................. SUCCESS [4.680s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.284s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.155s]
[INFO] Lens Regression ................................... SUCCESS [0.471s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:11.615s
[INFO] Finished at: Tue Feb 03 06:10:42 UTC 2015
[INFO] Final Memory: 108M/1112M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 30498: LENS-249: checkstyle changes for lens-server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30498/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 5:54 a.m.)


Review request for lens.


Bugs: LENS-249
    https://issues.apache.org/jira/browse/LENS-249


Repository: lens


Description
-------

draft.


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 9e173d2bfce3f6704ebc9f4342e31b149b8cfff8 
  lens-server/enunciate.xml de134d381a19a4927e94ef4ae72b7394554daa5e 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java faf1015b2fe02590db7778a97e2a83a632ab9f0e 
  lens-server/src/main/java/org/apache/lens/server/ConsistentStateFilter.java 5683466e0257c3ffcd1b3a5d999c69a746e9a651 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 377cb8baaae08da1ad64a79f3e52176ed4f5cea3 
  lens-server/src/main/java/org/apache/lens/server/IndexApp.java e14c039f1a1e9ef56e17b0b6e81dbc324751be2b 
  lens-server/src/main/java/org/apache/lens/server/IndexResource.java 8e874906bde551268fb1561db54296eb1f55f5c1 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 9cbf3549672fe10c7b9e458eaf7b6bdcf80f279f 
  lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 4b278bc27b36e17ced24f3d972273a2d5f05a369 
  lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 55e7ba781284995010edbc08b8c10e9a1e544697 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java d59e93b30ad0208701d368fb497ce96468127b73 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 71fcebde8d995c1e4785c38519de8ca3c056d20f 
  lens-server/src/main/java/org/apache/lens/server/LensService.java 3789c9a355a98d800dc9989e13c6d6c01e62ce75 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 96158dd63dba74be39d292ffb99729fc12721eaa 
  lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java 77025dfb72bebe6a21d288b92fa12148be68ad89 
  lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 83ecbb86233db2e239d8ddf14444be4855d8ea4c 
  lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 57f14196499c70104f583ca676a9310fafec9038 
  lens-server/src/main/java/org/apache/lens/server/metastore/AuthorizationFilter.java 315f6a3bf9ee912175ed85e3e8a4c9f617c3d8d7 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0b632328f8ef393c6026d7148d82ac05766e84d4 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 329d899f3054d32ee8afd74620258064910d2627 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 9cd5b5872257670659ee4700b551f729b619e54f 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 46589dfdcd500869a9fd5774e7b036cf387382f7 
  lens-server/src/main/java/org/apache/lens/server/query/AuthorizationFilter.java 3776989932cbefcb220a4a774b2e102c0168b842 
  lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java 8e8ba06db4dda282f3ef00127ed3829a0f2f6cff 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 4dc8daffd97a26bacc0ed6e48d8fc2adc1790b58 
  lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 90e7a487c127d5feea3ab0a96bf1423a6cc4b028 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java d4a71065789edd3f6ee5d79a19c8a85ea04694ea 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fa8e1eb6ddd3b99ae2488823a526e2c5bb31c482 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java 2ec2ba7828fef3cd0be1f7f4299c12e1a6d738e8 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java e835921df4406f88edab6043f902e30930d3000d 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 7c256f975c22c98c08956d3370b939c2f46a7dab 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaApp.java cf0190a35d2555673c9f5be31f4434f932bb61e7 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 8576af76d9b2e4be67122be8b05f9d96c04f0019 
  lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java e1b4cfcbf1f2ca3c75c3391f0f588aa304bd2d7d 
  lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java a0232ba4d5bd9ca78e267c17f67756efa3217e94 
  lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 96e13451853bbfe478505da15c5cfd5e577b647b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java fb30fd0f6e5eb0ea2861b678b0d80f9e60e29495 
  lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 5b09b841cec7123b10b6860ddbd2da1e7fe990d9 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 32a43f7b5e937849b3806cc8a6270ca654a3bb4c 
  lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java 933c508638810f2f26f85750a4b4cc4ef143241e 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 362a66c46920ae7e2850f6ed76caa92e084abdf2 
  lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java 39f9f72b6ab787d11bafcca86b23eca0278041d8 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LensStatistics.java cfc178d8c311455de68cab77bc434fecded8c4c4 
  lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java 184c14c8357c39cc359e55f70d7267cca573d918 
  lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java 1e0ab1b3a861341cc9f33b01f60eb0bbefedc57d 
  lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java 71452a8814997d3df7ad96ce0084c18316a8726e 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 67fd77bc53c7043ab0c02526654b1a5fad007f0f 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/PartitionEvent.java 2f101138dc7d83e87a72aad436f3eaaaf7f6d2c3 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 8430a3462bd9b89969dd7159c0ebd25fa8492f83 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java 3b1793b19f709847a88a81584b6c6a5d539020f1 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 082f7337fd0265cd4f3d5065a1e22a4e2a270211 
  lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java cbab724d0f6aec57a39cae4b9cad5d8fe35caea8 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 3dd4abf74e38671aa00dc8c2897260ec0e8301b4 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java cbf6551549ce78fe8ec1df6a2348fb4dd6d50316 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 1e75879ec167da90abb9969483a835dda982bcc8 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 6afb81c313396356aacf12b322ba2f102d50befb 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java be226e6e622302e2ec9c00b5c490c0b8c4b40cb0 
  lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java 4ac4d27ee4fd4ffc92a545d28dd1abb66800fea9 
  lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java 3d27241905b6bcf5012f15800e17272c9c25665e 
  lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 6fa5fd047669a0cc57413efe7851dd466f413fd2 
  lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java ba0da3e930f6a9319d967de1a39125d1917a34fa 
  lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 0129e11aae25e2964e4541589d0e8ec2bcd15b3a 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java fceaaaf9de50986a922316621ed18cc44964dfa5 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java 38de3870c402a5f34aadac69ac6a8318dd494555 
  lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java 405bdeac8f90bff43c030df120feb5707130a186 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java c282b3dbc8b85209d0f9f61ec7dafeba0065816b 
  lens-server/src/main/resources/lensserver-default.xml e983c7eb52d4bb1ee8d61e1e24594b9bfb453fd7 
  lens-server/src/main/resources/lenssession-default.xml 3839bbf94f94b05f63727a9860b5aef7a33c3414 
  lens-server/src/main/webapp/WEB-INF/web.xml 330da1f71ba33afc7c14ddc65d0443d0fec746ee 
  lens-server/src/main/webapp/static/index.html 6b2bb8d313068e63ef3184d5f2ab73b51b0d9640 
  lens-server/src/main/webapp/static/js/libs/jquery.flot.js 39f3e4cf3efe5c314d7c9d1ee3626acc84c0822e 
  lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java bda5957a979d3afa5b145712f23c88b3b9db25e8 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 1e2858d04b91338fb1b5de3041c856962a5af577 
  lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java f943045411e3bae877acb80d9be080453adfdfc9 
  lens-server/src/test/java/org/apache/lens/server/MockNonLensService.java 7cdec3e7e7bd9edbf5cf3dbab720e87ceeee7339 
  lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java 69850689ecbbe600f78f046e60ccf9e508262857 
  lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4cf63c8c4432e72fc92a3c197cfe52dfa311ecda 
  lens-server/src/test/java/org/apache/lens/server/TestResource.java 0adab4ead131e47947d977829c4972fea7d78f5a 
  lens-server/src/test/java/org/apache/lens/server/TestServerMode.java dcea1a7e9a6f27874d0f451d1de1ee7c89f7479c 
  lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java ff06df484656b20cc1f23a6afcb7877b0751e6e1 
  lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java 734389be638e5ec2783b0f0de008929ab09e81cf 
  lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 2254bd873831a194c87b66333ee3dfa51eb991b3 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java abfef50957026c335a8aa9481161919156418a43 
  lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java adcc7b510326b5caae646b9024d6084472a3f309 
  lens-server/src/test/java/org/apache/lens/server/common/LenServerTestException.java f2abfd9d3f2859fff04df1b609ae36b56ad3d109 
  lens-server/src/test/java/org/apache/lens/server/common/LensServerTestFileUtils.java 5962ebb619ee1c1aec7342f9e5de78622379e865 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e29227cbb132c9b146cf3eef16b572174bc68e7f 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 198cfb82df3c20c290b19b2c456fe5e81c53663b 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c0261003232013ab3511648e0d6bcb547471 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 1dd53c63a44add94546a318f2f03834698db66ac 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1ecd822a40361c149bcf1fc162dd14db7af3863d 
  lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 75ae2d3eee70973c17a7bb15d480814479131dd1 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dc0b4e6497c3ba4f58181204816b4bce16d867a0 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 13760f75d40ac85b1eafe29e441a849bbd508011 
  lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java b0b1cfa6aed91caf27fa6b4bcbef1b5dc614475e 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java 63fc10ba820c739317cc040c965b60f0a1f772da 
  lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java 3e6999fc4ecfd875136cbb3e346358eab25af44b 
  lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0fd92016da5f47559b6b5fee47c50c0eb5df94c4 
  lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java 21ebbdf3d7fc9bd83a45dff2e09586078cbf7e37 
  lens-server/src/test/resources/hive-site.xml 407b2b480f8e29f9ee0f29956efd48dd06e659e4 
  lens-server/src/test/resources/hivedriver-site.xml 79321b8dfe7387a4c4e73e9795093f73a41deb13 
  lens-server/src/test/resources/jdbcdriver-site.xml 116fddfe6b86900b91d2efeaa020499b12a78e0d 
  lens-server/src/test/resources/lens-site.xml d499cbe37cd26412e8d8b58fce8c3f50da532c29 
  lens-server/src/test/resources/user/database.xml 4bdc5addd2f14c43f1ca0c659b1f49f779c6a0c0 
  lens-server/src/test/resources/user/db_changelog.xml 052f34c328c6716e157101cb184736f6a58b9994 
  lens-server/src/test/resources/user/ldap_backed_db_changelog.xml 3f51010883f3e952133e07eeec5ac81df6f470ea 

Diff: https://reviews.apache.org/r/30498/diff/


Testing
-------


Thanks,

Rajat Khandelwal