You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2025/11/25 02:46:23 UTC
[PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
jt2594838 opened a new pull request, #16799:
URL: https://github.com/apache/iotdb/pull/16799
Due to cascading mods files are not properly set before performing a settle compaction, concurrent deletion with a settle compaction may be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16799:
URL: https://github.com/apache/iotdb/pull/16799#issuecomment-3573658380
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16799) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16799&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "shuwenwei (via GitHub)" <gi...@apache.org>.
shuwenwei commented on code in PR #16799:
URL: https://github.com/apache/iotdb/pull/16799#discussion_r2558384317
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java:
##########
@@ -136,7 +137,11 @@ protected boolean doCompaction() {
new File(
allSourceFiles.get(0).getTsFile().getAbsolutePath()
+ CompactionLogger.SETTLE_COMPACTION_LOG_NAME_SUFFIX);
+
try (SimpleCompactionLogger compactionLogger = new SimpleCompactionLogger(logFile)) {
+ CompactionUtils.prepareCompactionModFiles(
+ filesView.targetFilesInPerformer, filesView.sourceFilesInCompactionPerformer);
+
calculateSourceFilesAndTargetFiles();
Review Comment:
targetFilesInPerformer are calculated after this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16799:
URL: https://github.com/apache/iotdb/pull/16799#issuecomment-3573582317
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16799) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16799&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16799:
URL: https://github.com/apache/iotdb/pull/16799#issuecomment-3573747453
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16799?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 38.71%. Comparing base ([`2b47be7`](https://app.codecov.io/gh/apache/iotdb/commit/2b47be756ad8703ce3673973260983f10c4f94e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7a638b0`](https://app.codecov.io/gh/apache/iotdb/commit/7a638b08df24459b74c38984326e36084311b361?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16799 +/- ##
============================================
- Coverage 38.71% 38.71% -0.01%
Complexity 207 207
============================================
Files 5006 5006
Lines 331898 332049 +151
Branches 42214 42227 +13
============================================
+ Hits 128509 128564 +55
- Misses 203389 203485 +96
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16799?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #16799:
URL: https://github.com/apache/iotdb/pull/16799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix that settle compaction may lgnore some newly incoming deletions [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #16799:
URL: https://github.com/apache/iotdb/pull/16799#discussion_r2558439310
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java:
##########
@@ -136,7 +137,11 @@ protected boolean doCompaction() {
new File(
allSourceFiles.get(0).getTsFile().getAbsolutePath()
+ CompactionLogger.SETTLE_COMPACTION_LOG_NAME_SUFFIX);
+
try (SimpleCompactionLogger compactionLogger = new SimpleCompactionLogger(logFile)) {
+ CompactionUtils.prepareCompactionModFiles(
+ filesView.targetFilesInPerformer, filesView.sourceFilesInCompactionPerformer);
+
calculateSourceFilesAndTargetFiles();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org