You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/12/20 10:13:00 UTC
[GitHub] [orc] spektom opened a new pull request #584: Support big ORC files in Windows
spektom opened a new pull request #584:
URL: https://github.com/apache/orc/pull/584
Use 64-bit versions of fstat to support files bigger than 2GB.
Jira Issue: https://issues.apache.org/jira/browse/ORC-702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] spektom commented on pull request #584: ORC-702: [C++] Support big ORC files in Windows
Posted by GitBox <gi...@apache.org>.
spektom commented on pull request #584:
URL: https://github.com/apache/orc/pull/584#issuecomment-748601201
Quoting `fstat` man page:
"On modern 64-bit systems, life is simpler: there is a single stat() system call and the kernel deals with a stat structure that contains fields of a sufficient size."
So, apparently this isn't an issue in Linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #584: ORC-702: [C++] Support big ORC files in Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #584:
URL: https://github.com/apache/orc/pull/584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #584: ORC-702: Support big ORC files in Windows
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #584:
URL: https://github.com/apache/orc/pull/584#issuecomment-748600366
Hey @spektom is the issue Windows specific? Seems like the Cpp reader would face similar issues on a Linux env without the change right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #584: ORC-702: [C++] Support big ORC files in Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #584:
URL: https://github.com/apache/orc/pull/584#issuecomment-748942574
Welcome to the Apache ORC community, @spektom .
You are added to the Apache ORC contributor group and ORC-702 is assigned to you.
Could you make a PR to `branch-1.6`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] spektom commented on pull request #584: ORC-702: [C++] Support big ORC files in Windows
Posted by GitBox <gi...@apache.org>.
spektom commented on pull request #584:
URL: https://github.com/apache/orc/pull/584#issuecomment-748955659
>
Thanks @dongjoon-hyun !
Here's PR for `branch-1.6`: https://github.com/apache/orc/pull/585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org