You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/12/22 10:24:44 UTC

[spark] branch master updated: [SPARK-41364][CONNECT][PYTHON][FOLLOWUP] Remove the unnecessary `DataFrameType`

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 97811aaf233 [SPARK-41364][CONNECT][PYTHON][FOLLOWUP] Remove the unnecessary `DataFrameType`
97811aaf233 is described below

commit 97811aaf233f4d3a808116f690fd3ff72bae5763
Author: Ruifeng Zheng <ru...@apache.org>
AuthorDate: Thu Dec 22 19:24:30 2022 +0900

    [SPARK-41364][CONNECT][PYTHON][FOLLOWUP] Remove the unnecessary `DataFrameType`
    
    ### What changes were proposed in this pull request?
    remove the `DataFrameType`
    
    ### Why are the changes needed?
    do not need it
    
    ### Does this PR introduce _any_ user-facing change?
    no
    
    ### How was this patch tested?
    existing ut
    
    Closes #39174 from zhengruifeng/connect_broadcast_followup.
    
    Authored-by: Ruifeng Zheng <ru...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 python/pyspark/sql/connect/_typing.py   | 3 ---
 python/pyspark/sql/connect/functions.py | 5 +++--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/python/pyspark/sql/connect/_typing.py b/python/pyspark/sql/connect/_typing.py
index e23b34265c1..4962df1c7d5 100644
--- a/python/pyspark/sql/connect/_typing.py
+++ b/python/pyspark/sql/connect/_typing.py
@@ -28,7 +28,6 @@ import decimal
 
 from pyspark.sql.connect.column import Column
 
-from pyspark.sql.connect.dataframe import DataFrame
 
 ColumnOrName = Union[Column, str]
 
@@ -42,8 +41,6 @@ DecimalLiteral = decimal.Decimal
 
 DateTimeLiteral = Union[datetime.datetime, datetime.date]
 
-DataFrameType = DataFrame
-
 
 class FunctionBuilderCallable(Protocol):
     def __call__(self, *_: ColumnOrName) -> Column:
diff --git a/python/pyspark/sql/connect/functions.py b/python/pyspark/sql/connect/functions.py
index 01f0efaf7d8..1e1911add14 100644
--- a/python/pyspark/sql/connect/functions.py
+++ b/python/pyspark/sql/connect/functions.py
@@ -32,7 +32,8 @@ from pyspark.sql.connect.column import (
 from typing import Any, TYPE_CHECKING, Union, List, overload, Optional, Tuple, Callable, ValuesView
 
 if TYPE_CHECKING:
-    from pyspark.sql.connect._typing import ColumnOrName, DataFrameType
+    from pyspark.sql.connect._typing import ColumnOrName
+    from pyspark.sql.connect.dataframe import DataFrame
 
 
 def _to_col(col: "ColumnOrName") -> Column:
@@ -221,7 +222,7 @@ def bitwise_not(col: "ColumnOrName") -> Column:
     return _invoke_function_over_columns("~", col)
 
 
-def broadcast(df: "DataFrameType") -> "DataFrameType":
+def broadcast(df: "DataFrame") -> "DataFrame":
     """
     Marks a DataFrame as small enough for use in broadcast joins.
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org