You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/28 15:27:24 UTC
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
slawekjaranowski opened a new pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52
`plugin.xml` descriptor - should only contain dependencies in compile scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slachiewicz merged pull request #52: [MPLUGIN-382] exclude dependency in provided scope from plugin descriptor
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52#issuecomment-981104491
@cstamas Can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52#discussion_r757956467
##########
File path: maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java
##########
@@ -122,14 +122,19 @@ public static void element( XMLWriter w, String name, String value, boolean asTe
/**
* @param artifacts not null collection of <code>Artifact</code>
- * @return list of component dependencies
+ * @return list of component dependencies, only in compile scope
*/
public static List<ComponentDependency> toComponentDependencies( Collection<Artifact> artifacts )
{
List<ComponentDependency> componentDeps = new LinkedList<>();
for ( Artifact artifact : artifacts )
{
+ if ( !Artifact.SCOPE_COMPILE.equals( artifact.getScope() ) )
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #52: [MPLUGIN-382] only dependency in compile scope in plugin descriptor
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #52:
URL: https://github.com/apache/maven-plugin-tools/pull/52#discussion_r757943160
##########
File path: maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/GeneratorUtils.java
##########
@@ -122,14 +122,19 @@ public static void element( XMLWriter w, String name, String value, boolean asTe
/**
* @param artifacts not null collection of <code>Artifact</code>
- * @return list of component dependencies
+ * @return list of component dependencies, only in compile scope
*/
public static List<ComponentDependency> toComponentDependencies( Collection<Artifact> artifacts )
{
List<ComponentDependency> componentDeps = new LinkedList<>();
for ( Artifact artifact : artifacts )
{
+ if ( !Artifact.SCOPE_COMPILE.equals( artifact.getScope() ) )
Review comment:
I would rather make `SCOPE = PROVIDED` (then continue). What about runtime scope? Just to be on safe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org