You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by jo...@apache.org on 2022/12/07 10:34:16 UTC

[incubator-eventmesh] branch master updated: [ISSUE #2469]add synchronized bracket in EventMeshMessageTCPSubClient (#2470)

This is an automated email from the ASF dual-hosted git repository.

jonyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new ba1bbaaad [ISSUE #2469]add synchronized bracket in EventMeshMessageTCPSubClient (#2470)
ba1bbaaad is described below

commit ba1bbaaadb949baab5f85a047faa705ff35fe056
Author: MajorHe1 <53...@users.noreply.github.com>
AuthorDate: Wed Dec 7 18:34:11 2022 +0800

    [ISSUE #2469]add synchronized bracket in EventMeshMessageTCPSubClient (#2470)
    
    * add synchronized bracket in EventMeshMessageTCPSubClient
    
    * move synchronized key word to subscriber method
    
    * revert previous commit
---
 .../tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java b/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
index 008fb7e92..fab860d26 100644
--- a/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
+++ b/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
@@ -73,9 +73,11 @@ class EventMeshMessageTCPSubClient extends TcpClient implements EventMeshTCPSubC
             super.reconnect();
             hello();
             if (!CollectionUtils.isEmpty(subscriptionItems)) {
-                for (SubscriptionItem item : subscriptionItems) {
-                    Package request = MessageUtils.subscribe(item.getTopic(), item.getMode(), item.getType());
-                    this.io(request, EventMeshCommon.DEFAULT_TIME_OUT_MILLS);
+                synchronized (subscriptionItems) {
+                    for (SubscriptionItem item : subscriptionItems) {
+                        Package request = MessageUtils.subscribe(item.getTopic(), item.getMode(), item.getType());
+                        this.io(request, EventMeshCommon.DEFAULT_TIME_OUT_MILLS);
+                    }                 
                 }
             }
             listen();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org