[GitHub] [flink] wsry commented on pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

[GitBox <gi...@apache.org>]

wsry commented on pull request #18505:
URL: https://github.com/apache/flink/pull/18505#issuecomment-1033686698


   > Very thanks @wsry for the PR! I have left some comments.
   > 
   > For the long run, I tend to we move the difference implementation to the implementation class, like the strategy to split write buffers and sort buffers and how they write the buffers to the files. Perhaps we could create a new issue for the future refactor?
   > 
   > Also if possible I tend to we rename the classes to `DataBuffer`, `HashBasedDataBuffer` and `SortBasedDataBuffer` and also the variables to avoid reuse the word `sort`.
   
   @gaoyunhaii Thanks for the review and comments. I agree that we can rename the sort buffer class in this PR. As for other refactor, I will create a new ticket to do it latter. I will update the PR soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org