[jira] [Resolved] (SAMZA-1872) taskStoreRestorationMetrics uses storeName in the metric name but the metric is only for the whole task

["Prateek Maheshwari (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prateek Maheshwari resolved SAMZA-1872.
---------------------------------------
    Resolution: Fixed

Ray fixed this in a recent PR.

> taskStoreRestorationMetrics uses storeName in the metric name but the metric is only for the whole task
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-1872
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1872
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Cameron Lee
>            Priority: Major
>              Labels: newbie
>
> In SamzaContainerMetrics, there is a taskStoreRestorationMetrics which is a map from task name to a gauge. The name of this metric includes the store name, but the value of the metric doesn't correspond to the specific store. The value of the metric corresponds to the whole task restoration. This is misleading, because it will look like the restoration time for a single store is the full restoration time, and all other stores will have a zero restoration time.
> This could be fixed by removing the store name from the metric so it is not misleading (just report task-level restoration) or by adding the store name as part of the key to find the metric (report store-level restoration. It would also be good to move this metric into TaskInstanceMetrics since it is task-specific anyways.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)