You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:07:28 UTC

[GitHub] [kafka] jsancio opened a new pull request #10902: KAFKA-12837: Process entire batch reader in the commit handler

jsancio opened a new pull request #10902:
URL: https://github.com/apache/kafka/pull/10902


   Process entire batch and make sure that `hasNext` is called before calling `next` on the iterator.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10902: KAFKA-12837: Process entire batch reader in the commit handler

Posted by GitBox <gi...@apache.org>.

hachikuji merged pull request #10902:
URL: https://github.com/apache/kafka/pull/10902


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #10902: KAFKA-12837: Process entire batch reader in the commit handler

Posted by GitBox <gi...@apache.org>.

jsancio commented on pull request #10902:
URL: https://github.com/apache/kafka/pull/10902#issuecomment-864163615


   > Are any test cases worthwhile? For example, maybe one with an empty iterator?
   
   Added a test for an empty control batch. Confirmed that the test fails without this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #10902: KAFKA-12837: Process entire batch reader in the commit handler

Posted by GitBox <gi...@apache.org>.

hachikuji commented on pull request #10902:
URL: https://github.com/apache/kafka/pull/10902#issuecomment-863788401






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org