[jira] [Commented] (ZOOKEEPER-2330) ZooKeeper close API does not close Login thread.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021944#comment-15021944 ] 

Hadoop QA commented on ZOOKEEPER-2330:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12773813/ZOOKEEPER-2330-01.patch
  against trunk revision 1715590.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2966//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2966//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2966//console

This message is automatically generated.

> ZooKeeper close API does not close Login thread.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-2330
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2330
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.5.0
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2330-01.patch
>
>
> When kerberos is used as authentication mechanism, one login thread runs in the background for ZooKeeper client as well ZooKeepr server.
> This problem is related to Zookeeper client and the scenario is as follows:
> # Main application connects to Zookeeper
> {code}
> ZooKeeper zooKeeper = new ZooKeeper(zookeeperConnectionString, sessionTimeout, this)
> {code}
> # Completes it is work with zookeeper
> # calls close() on zookeeper, and continues with rest of the application specific work
> Thread dump, taken after 3rd step, shows that login thread is still alive
> {code}
> "Thread-1" daemon prio=6 tid=0x04842c00 nid=0x1f04 waiting on condition [0x05b7f000]
>    java.lang.Thread.State: TIMED_WAITING (sleeping)
> 	at java.lang.Thread.sleep(Native Method)
> 	at org.apache.zookeeper.Login$1.run(Login.java:180)
> 	at java.lang.Thread.run(Thread.java:722)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)