You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/04 08:32:29 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2063: Fix libcxx for sim/macOS

yamt commented on a change in pull request #2063:
URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r551175295



##########
File path: libs/libc/sched/task_startup.c
##########
@@ -94,6 +94,11 @@ extern uintptr_t _etext;
 static void cxx_initialize(void)
 {
 #ifdef CONFIG_HAVE_CXXINITIALIZE
+#if defined(CONFIG_ARCH_SIM) && defined(CONFIG_HOST_MACOS)
+  extern void macho_call_saved_init_funcs(void);

Review comment:
       i can't think of a better place. neither up_initialize or board_initialize doesn't seem appropriate to me.
   
   i can introduce ARCH_HAVE_CXXINITIALIZE or something along the line if you prefer.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org