[GitHub] [arrow] raulcd commented on a diff in pull request #13427: ARROW-16892: [Dev][Release] Fix version sorting on merge_arrow script

[GitBox <gi...@apache.org>]

raulcd commented on code in PR #13427:
URL: https://github.com/apache/arrow/pull/13427#discussion_r905187272


##########
dev/merge_arrow_pr.py:
##########
@@ -122,6 +122,31 @@ def fix_version_from_branch(branch, versions):
                     for project in SUPPORTED_PROJECTS]
 
 
+class ComparableVersion(object):

Review Comment:
   it is slightly more complex because I have to cope for the possible versions like `cpp-1.2.0` in the case of PARQUET project. I am confused that this script should be used for the APACHE PARQUET project, is this still relevant?
   The following works but I find it extremely unreadable.
   ```
   key=(lambda x: tuple(int(_) for _ in ((lambda y: y.name.split("-")[1] if "-" in y.name else y.name)(x)).split(".")))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org