You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/08/06 03:42:20 UTC
[GitHub] [incubator-shenyu] Technoboy- opened a new pull request #1886: Fix the ConcurrentModificationException by revert #1832
Technoboy- opened a new pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886
##Motivation
#1832 has involved a concurrent issue with below trace. The easy way to fix is reverting.
```
07:14:45.276 [shenyu-upstream-health-check-request-4] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] upstream health check failed, server is offline.
07:14:45.320 [shenyu-upstream-health-check-3] ERROR org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Meet problem:
java.util.ConcurrentModificationException: null
at java.util.ArrayList.forEach(ArrayList.java:1262)
at org.apache.shenyu.common.healthcheck.HealthCheckTask.lambda$check$3(HealthCheckTask.java:144)
at java.util.concurrent.ConcurrentHashMap.forEach(ConcurrentHashMap.java:1597)
at org.apache.shenyu.common.healthcheck.HealthCheckTask.check(HealthCheckTask.java:144)
at org.apache.shenyu.common.healthcheck.HealthCheckTask.doHealthCheck(HealthCheckTask.java:139)
at org.apache.shenyu.common.healthcheck.HealthCheckTask.healthCheck(HealthCheckTask.java:127)
at org.apache.shenyu.common.healthcheck.HealthCheckTask.run(HealthCheckTask.java:118)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
07:14:46.266 [shenyu-upstream-health-check-request-4] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] upstream http://www.baidu.com health check passed, server is back online.
07:14:47.300 [main] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] all upstream as removed.
07:14:47.302 [main] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] all upstream as removed.
07:14:47.304 [main] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] upstream null was removed.
07:14:47.306 [main] INFO org.apache.shenyu.common.healthcheck.HealthCheckTask - [Health Check] Selector [null] upstream null was removed.
Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.653 s <<< FAILURE! - in org.apache.shenyu.common.healthcheck.HealthCheckTaskTest
Error: org.apache.shenyu.common.healthcheck.HealthCheckTaskTest.testRun Time elapsed: 6.37 s <<< FAILURE!
java.lang.AssertionError
at org.apache.shenyu.common.healthcheck.HealthCheckTaskTest.testRun(HealthCheckTaskTest.java:91)
```
But this class have some defects that not support concurrent event though it's using synchronized in some snippets.
Current defects:
If healthCheck invoked by ScheduledThreadPoolExecutor, this will block other thread to do triggerRemoveOne/triggerAddOne.
And it's not support shutdown gracefully.
Shenyu is a gateway project which async and latency is sensitive to user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1886: Fix the ConcurrentModificationException by revert #1832
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886#issuecomment-893980893
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1886](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c4add5) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/1754b8a16d4c6bdd0a8bb9e79cce589b7bc302ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1754b8a) will **increase** coverage by `0.35%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
+ Coverage 67.90% 68.25% +0.35%
- Complexity 2646 2708 +62
============================================
Files 489 492 +3
Lines 10976 11173 +197
Branches 1078 1092 +14
============================================
+ Hits 7453 7626 +173
- Misses 2967 2975 +8
- Partials 556 572 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/common/healthcheck/HealthCheckTask.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9oZWFsdGhjaGVjay9IZWFsdGhDaGVja1Rhc2suamF2YQ==) | `79.71% <100.00%> (+1.58%)` | :arrow_up: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `35.13% <0.00%> (-18.92%)` | :arrow_down: |
| [...va/org/apache/shenyu/metrics/config/JmxConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3Mtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvbWV0cmljcy9jb25maWcvSm14Q29uZmlnLmphdmE=) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `57.14% <0.00%> (-2.05%)` | :arrow_down: |
| [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <0.00%> (-1.70%)` | :arrow_down: |
| [...prometheus/register/PrometheusMetricsRegister.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9yZWdpc3Rlci9Qcm9tZXRoZXVzTWV0cmljc1JlZ2lzdGVyLmphdmE=) | `50.00% <0.00%> (-1.17%)` | :arrow_down: |
| [...rics/prometheus/service/PrometheusBootService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9zZXJ2aWNlL1Byb21ldGhldXNCb290U2VydmljZS5qYXZh) | `57.14% <0.00%> (-0.44%)` | :arrow_down: |
| [...in/java/org/apache/shenyu/spi/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwaS9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `89.47% <0.00%> (ø)` | |
| [...in/java/org/apache/shenyu/web/logo/ShenyuLogo.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2dvL1NoZW55dUxvZ28uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/shenyu/web/handler/GlobalErrorHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9oYW5kbGVyL0dsb2JhbEVycm9ySGFuZGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1754b8a...1c4add5](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1886: Fix the ConcurrentModificationException by revert #1832
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886#issuecomment-893980893
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1886](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c4add5) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/1754b8a16d4c6bdd0a8bb9e79cce589b7bc302ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1754b8a) will **increase** coverage by `0.23%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
+ Coverage 67.90% 68.13% +0.23%
- Complexity 2646 2703 +57
============================================
Files 489 492 +3
Lines 10976 11173 +197
Branches 1078 1092 +14
============================================
+ Hits 7453 7613 +160
- Misses 2967 2985 +18
- Partials 556 575 +19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/common/healthcheck/HealthCheckTask.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9oZWFsdGhjaGVjay9IZWFsdGhDaGVja1Rhc2suamF2YQ==) | `79.71% <100.00%> (+1.58%)` | :arrow_up: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `66.66% <0.00%> (-27.78%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `35.13% <0.00%> (-18.92%)` | :arrow_down: |
| [...va/org/apache/shenyu/metrics/config/JmxConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3Mtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvbWV0cmljcy9jb25maWcvSm14Q29uZmlnLmphdmE=) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `56.84% <0.00%> (-7.37%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `57.14% <0.00%> (-2.05%)` | :arrow_down: |
| [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <0.00%> (-1.70%)` | :arrow_down: |
| [...elimiter/handler/RateLimiterPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJhdGVsaW1pdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JhdGVsaW1pdGVyL2hhbmRsZXIvUmF0ZUxpbWl0ZXJQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `69.69% <0.00%> (-1.52%)` | :arrow_down: |
| [...prometheus/register/PrometheusMetricsRegister.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9yZWdpc3Rlci9Qcm9tZXRoZXVzTWV0cmljc1JlZ2lzdGVyLmphdmE=) | `50.00% <0.00%> (-1.17%)` | :arrow_down: |
| [...rics/prometheus/service/PrometheusBootService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9zZXJ2aWNlL1Byb21ldGhldXNCb290U2VydmljZS5qYXZh) | `57.14% <0.00%> (-0.44%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1754b8a...1c4add5](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1886: Fix the ConcurrentModificationException by revert #1832
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886#issuecomment-893980893
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1886](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c4add5) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/1754b8a16d4c6bdd0a8bb9e79cce589b7bc302ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1754b8a) will **increase** coverage by `0.52%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
+ Coverage 67.90% 68.42% +0.52%
- Complexity 2646 2712 +66
============================================
Files 489 492 +3
Lines 10976 11173 +197
Branches 1078 1092 +14
============================================
+ Hits 7453 7645 +192
+ Misses 2967 2956 -11
- Partials 556 572 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/common/healthcheck/HealthCheckTask.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9oZWFsdGhjaGVjay9IZWFsdGhDaGVja1Rhc2suamF2YQ==) | `79.71% <100.00%> (+1.58%)` | :arrow_up: |
| [...va/org/apache/shenyu/metrics/config/JmxConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3Mtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvbWV0cmljcy9jb25maWcvSm14Q29uZmlnLmphdmE=) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <0.00%> (-1.70%)` | :arrow_down: |
| [...prometheus/register/PrometheusMetricsRegister.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9yZWdpc3Rlci9Qcm9tZXRoZXVzTWV0cmljc1JlZ2lzdGVyLmphdmE=) | `50.00% <0.00%> (-1.17%)` | :arrow_down: |
| [...rics/prometheus/service/PrometheusBootService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L21ldHJpY3MvcHJvbWV0aGV1cy9zZXJ2aWNlL1Byb21ldGhldXNCb290U2VydmljZS5qYXZh) | `57.14% <0.00%> (-0.44%)` | :arrow_down: |
| [...in/java/org/apache/shenyu/spi/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwaS9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `89.47% <0.00%> (ø)` | |
| [...in/java/org/apache/shenyu/web/logo/ShenyuLogo.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2dvL1NoZW55dUxvZ28uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/shenyu/web/handler/GlobalErrorHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9oYW5kbGVyL0dsb2JhbEVycm9ySGFuZGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../shenyu/web/configuration/ShenyuConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9jb25maWd1cmF0aW9uL1NoZW55dUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...shenyu/web/fallback/DefaultFallbackController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9mYWxsYmFjay9EZWZhdWx0RmFsbGJhY2tDb250cm9sbGVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1754b8a...1c4add5](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1886: Fix the ConcurrentModificationException by revert #1832
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886#issuecomment-893980893
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1886](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c4add5) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/1754b8a16d4c6bdd0a8bb9e79cce589b7bc302ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1754b8a) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
+ Coverage 67.90% 67.94% +0.04%
- Complexity 2646 2700 +54
============================================
Files 489 492 +3
Lines 10976 11170 +194
Branches 1078 1090 +12
============================================
+ Hits 7453 7590 +137
- Misses 2967 3007 +40
- Partials 556 573 +17
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/common/healthcheck/HealthCheckTask.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9oZWFsdGhjaGVjay9IZWFsdGhDaGVja1Rhc2suamF2YQ==) | `79.71% <100.00%> (+1.58%)` | :arrow_up: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `25.67% <0.00%> (-28.38%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `66.66% <0.00%> (-27.78%)` | :arrow_down: |
| [...che/shenyu/admin/model/vo/SelectorConditionVO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvdm8vU2VsZWN0b3JDb25kaXRpb25WTy5qYXZh) | `71.42% <0.00%> (-14.29%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-9.71%)` | :arrow_down: |
| [...va/org/apache/shenyu/metrics/config/JmxConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LW1ldHJpY3Mvc2hlbnl1LW1ldHJpY3Mtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvbWV0cmljcy9jb25maWcvSm14Q29uZmlnLmphdmE=) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `56.84% <0.00%> (-7.37%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `57.14% <0.00%> (-2.05%)` | :arrow_down: |
| [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <0.00%> (-1.70%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1886/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1754b8a...1c4add5](https://codecov.io/gh/apache/incubator-shenyu/pull/1886?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #1886: Fix the ConcurrentModificationException by revert #1832
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #1886:
URL: https://github.com/apache/incubator-shenyu/pull/1886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org