You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2012/10/20 02:19:22 UTC
Review Request: GIRAPH-382: ZooKeeperExt should handle
ConnectionLossException by retrying
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7674/
-----------------------------------------------------------
Review request for giraph.
Description
-------
ZooKeeperExt now uses composition to ensure that all operations can handle ConnectionLossException.
This addresses bug GIRAPH-382.
https://issues.apache.org/jira/browse/GIRAPH-382
Diffs
-----
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/BspCase.java 1399984
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1399984
Diff: https://reviews.apache.org/r/7674/diff/
Testing
-------
Unittests.
Thanks,
Avery Ching
Re: Review Request: GIRAPH-382: ZooKeeperExt should handle
ConnectionLossException by retrying
Posted by Avery Ching <av...@gmail.com>.
> On Oct. 22, 2012, 9:31 p.m., Alessandro Presta wrote:
> > Looks good to me, +1.
> > Feels a bit like manually decorating each method, but it's simple anyway.
Thanks for the review Alessandro.
> On Oct. 22, 2012, 9:31 p.m., Alessandro Presta wrote:
> > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java, line 175
> > <https://reviews.apache.org/r/7674/diff/2/?file=178355#file178355line175>
> >
> > zK -> zk
Thanks! I've fixed this in the commit.
- Avery
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7674/#review12665
-----------------------------------------------------------
On Oct. 20, 2012, 12:19 a.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7674/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2012, 12:19 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> ZooKeeperExt now uses composition to ensure that all operations can handle ConnectionLossException.
>
>
> This addresses bug GIRAPH-382.
> https://issues.apache.org/jira/browse/GIRAPH-382
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/BspCase.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1399984
>
> Diff: https://reviews.apache.org/r/7674/diff/
>
>
> Testing
> -------
>
> Unittests.
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-382: ZooKeeperExt should handle
ConnectionLossException by retrying
Posted by Alessandro Presta <al...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7674/#review12665
-----------------------------------------------------------
Looks good to me, +1.
Feels a bit like manually decorating each method, but it's simple anyway.
http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java
<https://reviews.apache.org/r/7674/#comment27006>
zK -> zk
- Alessandro Presta
On Oct. 20, 2012, 12:19 a.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7674/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2012, 12:19 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> ZooKeeperExt now uses composition to ensure that all operations can handle ConnectionLossException.
>
>
> This addresses bug GIRAPH-382.
> https://issues.apache.org/jira/browse/GIRAPH-382
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/BspCase.java 1399984
> http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1399984
>
> Diff: https://reviews.apache.org/r/7674/diff/
>
>
> Testing
> -------
>
> Unittests.
>
>
> Thanks,
>
> Avery Ching
>
>