You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/02/25 21:59:00 UTC

[jira] [Commented] (CALCITE-3821) RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset

    [ https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044932#comment-17044932 ] 

Julian Hyde commented on CALCITE-3821:
--------------------------------------

* You changed the method names but not the comments. Very confusing.
 * The constant {{B}} is now unused.
 * Can you find out why {{B}} was introduced?

> RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-3821
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3821
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Xiening Dai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The check of containsMultiset() is shortcut by a "false" constant. Also what the function really does is to check rel node does *not* contain window aggs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)