You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/19 09:44:04 UTC
[jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical
plans consistent test
[ https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017134#comment-16017134 ]
ASF GitHub Bot commented on FLINK-6617:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3943
[FLINK-6617][table] Improve JAVA and SCALA logical plans consistent test
In this PR. I had make some changes as follows:
1. Add all the tableAPI AVA and SCALA logical plans consistent test.
2. Add `validation` folder for steam which keep consistent with batch.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6617][table] Improve JAVA and SCALA logical plans consistent test")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6617-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3943
----
commit 01d7398238b49eae45138ed7318969c61e52424a
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-05-18T05:02:24Z
[FLINK-6617][table] Improve JAVA and SCALA logical plans consistent test
----
> Improve JAVA and SCALA logical plans consistent test
> ----------------------------------------------------
>
> Key: FLINK-6617
> URL: https://issues.apache.org/jira/browse/FLINK-6617
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently,we need some `StringExpression` test,for all JAVA and SCALA API.
> Such as:`GroupAggregations`,`GroupWindowAggregaton`(Session,Tumble),`Calc` etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)