You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/02/03 16:05:03 UTC
[GitHub] [incubator-eventmesh] mxsm opened a new pull request, #3044: [ISSUE #3028] Refactor ThreadFactory implement
mxsm opened a new pull request, #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #3028
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
- *Refactor ThreadFactory implement.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#issuecomment-1419188287
@jonyangx done, the test case not pass, this pr has fix it #3058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096618554
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -75,8 +75,7 @@ public abstract class TcpClient implements Closeable {
private transient ScheduledFuture<?> heartTask;
protected static final ScheduledThreadPoolExecutor scheduler = new ScheduledThreadPoolExecutor(
Review Comment:
@jonyangx I will fix those problems and resubmit this pr later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096602798
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/EventMeshThreadFactory.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.common;
+
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import lombok.Getter;
+
+public class EventMeshThreadFactory implements ThreadFactory {
+
+ @Getter
+ private final String threadNamePrefix;
+ private final AtomicInteger threadIndex;
+ private final boolean daemon;
+ private Integer priority;
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final AtomicInteger threadIndex, final boolean daemon,
+ final Integer priority) {
+ this.threadNamePrefix = threadNamePrefix;
+ this.threadIndex = threadIndex;
+ this.daemon = daemon;
+ this.priority = priority;
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final AtomicInteger threadIndex,
+ final boolean daemon) {
+ this(threadNamePrefix, threadIndex, daemon, null);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final boolean daemon, final Integer priority) {
+ this(threadNamePrefix, new AtomicInteger(0), daemon, priority);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final boolean daemon) {
+ this(threadNamePrefix, new AtomicInteger(0), daemon);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix) {
+ this(threadNamePrefix, new AtomicInteger(0), false);
+ }
+
+ /**
+ * Constructs a new {@code Thread}. Implementations may also initialize
+ * priority, name, daemon status, {@code ThreadGroup}, etc.
+ *
+ * @param runnable a runnable to be executed by new thread instance
+ * @return constructed thread, or {@code null} if the request to
+ * create a thread is rejected
+ */
+ @Override
+ public Thread newThread(Runnable runnable) {
Review Comment:
Suggest add abstract method newThread(final Runnable runnable ) in parent Class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096602858
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/ThreadPoolFactory.java:
##########
@@ -24,9 +24,6 @@
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicInteger;
-
-import com.google.common.util.concurrent.ThreadFactoryBuilder;
public class ThreadPoolFactory {
Review Comment:
It's look like a utility Class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#issuecomment-1417066274
@mxsm pls fix checkstyle check error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096603490
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -75,8 +75,7 @@ public abstract class TcpClient implements Closeable {
private transient ScheduledFuture<?> heartTask;
protected static final ScheduledThreadPoolExecutor scheduler = new ScheduledThreadPoolExecutor(
Review Comment:
Suggest add createScheduledThreadPoolExecutor in Threadfactory Class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#issuecomment-1416710900
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3044](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (283fc44) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/022f892204a1672f24cb5ae596a6f417fe57f433?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (022f892) will **increase** coverage by `0.01%`.
> The diff coverage is `21.34%`.
```diff
@@ Coverage Diff @@
## master #3044 +/- ##
============================================
+ Coverage 12.84% 12.85% +0.01%
- Complexity 1095 1097 +2
============================================
Files 548 548
Lines 28623 28589 -34
Branches 2847 2836 -11
============================================
- Hits 3676 3675 -1
+ Misses 24650 24618 -32
+ Partials 297 296 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../connector/rabbitmq/consumer/RabbitmqConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yYWJiaXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yYWJiaXRtcS9jb25zdW1lci9SYWJiaXRtcUNvbnN1bWVyLmphdmE=) | `73.17% <ø> (ø)` | |
| [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY2xpZW50L2ltcGwvY29uc3VtZXIvQ29uc3VtZU1lc3NhZ2VDb25jdXJyZW50bHlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `1.14% <0.00%> (ø)` | |
| [...eventmesh/runtime/boot/AbstractRemotingServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RSZW1vdGluZ1NlcnZlci5qYXZh) | `5.12% <0.00%> (+0.87%)` | :arrow_up: |
| [...he/eventmesh/runtime/boot/EventMeshGrpcServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoR3JwY1NlcnZlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoSFRUUFNlcnZlci5qYXZh) | `0.56% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/EventMeshTCPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoVENQU2VydmVyLmphdmE=) | `0.58% <ø> (ø)` | |
| [.../runtime/core/protocol/grpc/retry/GrpcRetryer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9yZXRyeS9HcnBjUmV0cnllci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/protocol/http/consumer/EventMeshConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../runtime/core/protocol/http/retry/HttpRetryer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9yZXRyeS9IdHRwUmV0cnllci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/3044?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096627067
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/EventMeshThreadFactory.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.common;
+
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import lombok.Getter;
+
+public class EventMeshThreadFactory implements ThreadFactory {
+
+ @Getter
+ private final String threadNamePrefix;
+ private final AtomicInteger threadIndex;
+ private final boolean daemon;
+ private Integer priority;
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final AtomicInteger threadIndex, final boolean daemon,
+ final Integer priority) {
+ this.threadNamePrefix = threadNamePrefix;
+ this.threadIndex = threadIndex;
+ this.daemon = daemon;
+ this.priority = priority;
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final AtomicInteger threadIndex,
+ final boolean daemon) {
+ this(threadNamePrefix, threadIndex, daemon, null);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final boolean daemon, final Integer priority) {
+ this(threadNamePrefix, new AtomicInteger(0), daemon, priority);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix, final boolean daemon) {
+ this(threadNamePrefix, new AtomicInteger(0), daemon);
+ }
+
+ public EventMeshThreadFactory(final String threadNamePrefix) {
+ this(threadNamePrefix, new AtomicInteger(0), false);
+ }
+
+ /**
+ * Constructs a new {@code Thread}. Implementations may also initialize
+ * priority, name, daemon status, {@code ThreadGroup}, etc.
+ *
+ * @param runnable a runnable to be executed by new thread instance
+ * @return constructed thread, or {@code null} if the request to
+ * create a thread is rejected
+ */
+ @Override
+ public Thread newThread(Runnable runnable) {
Review Comment:
newThread method belongs to java.util.concurrent.ThreadFactory, and EventMeshThreadFactory is largely unchanged. so add `newThread(final Runnable runnable )` is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096618554
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -75,8 +75,7 @@ public abstract class TcpClient implements Closeable {
private transient ScheduledFuture<?> heartTask;
protected static final ScheduledThreadPoolExecutor scheduler = new ScheduledThreadPoolExecutor(
Review Comment:
I will fix those problems and resubmit this pr later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org