You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/27 13:07:42 UTC

[jira] [Commented] (NIFI-3643) nifi-api: deserialization error of nifiVersion field due to capitalization

    [ https://issues.apache.org/jira/browse/NIFI-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943229#comment-15943229 ] 

ASF GitHub Bot commented on NIFI-3643:
--------------------------------------

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/1626

    NIFI-3643: Fixing capitalization in Java Property

    NIFI-3643:
    - Addressing incorrect capitalization in VersionInfoDTO in NiFiVersion.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-3643

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1626
    
----
commit 7ecdfe0bad832f9d469960fe561b3b47add206a0
Author: Matt Gilman <ma...@gmail.com>
Date:   2017-03-27T13:06:37Z

    NIFI-3643:
    - Addressing incorrect capitalization in VersionInfoDTO in NiFiVersion.

----


> nifi-api: deserialization error of nifiVersion field due to capitalization
> --------------------------------------------------------------------------
>
>                 Key: NIFI-3643
>                 URL: https://issues.apache.org/jira/browse/NIFI-3643
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.2.0, 1.1.1
>         Environment: OpenJDK8. gson, nifi-1.1.0
>            Reporter: David Arllen
>            Assignee: Matt Gilman
>            Priority: Trivial
>             Fix For: 1.2.0, 1.1.1
>
>
> The response from `/nifi-api/system-diagnostics` includes the field name of 'niFiVersion'.  The gson serialization library works on reflection and expects 'nifiVersion' to be the field name because the class private field 'nifiVersion' does not have a capital F.
> Resolution is expected to involve only the class 'VersionInfoDTO'.  The fix would be matching the field capitalization with the capitalization of the associated getter and setter.
> Without this fix, a gson FieldNamingStrategy is required to artifically map the api-provided 'niFiVersion' field name to the reflection-expected 'nifiVersion'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)