You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 04:46:53 UTC
[GitHub] [airflow] dimberman opened a new pull request #11369: Users can specify sub-secrets and paths k8spodop
dimberman opened a new pull request #11369:
URL: https://github.com/apache/airflow/pull/11369
Allows users to specify items for specific key path projections
when using the airflow.kubernetes.secret.Secret class
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11369: Users can specify sub-secrets and paths k8spodop
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11369:
URL: https://github.com/apache/airflow/pull/11369#issuecomment-706650599
@a-poptsov Tbh probably not :/ (though if you want to handle the backporting we could potentially squeeze it). That said 1.10.13 will have the ability to use pod_template_file and pod_spec, both of which give you full access to the k8s API. (Also 2.0 alpha should be coming out this week so you could also try that out and it'll be there :) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] a-poptsov commented on pull request #11369: Users can specify sub-secrets and paths k8spodop
Posted by GitBox <gi...@apache.org>.
a-poptsov commented on pull request #11369:
URL: https://github.com/apache/airflow/pull/11369#issuecomment-706649581
@dimberman Great job. Is it possible to make it available for v1.X users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] a-poptsov commented on pull request #11369: Users can specify sub-secrets and paths k8spodop
Posted by GitBox <gi...@apache.org>.
a-poptsov commented on pull request #11369:
URL: https://github.com/apache/airflow/pull/11369#issuecomment-706656170
@dimberman having it in 1.10.13 will be really nice. For now I have to apply some dirty hacks to have the same ability. Migration to 2.0 will be really nice but it will take some time for production/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11369: Users can specify sub-secrets and paths k8spodop
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11369:
URL: https://github.com/apache/airflow/pull/11369#issuecomment-706715679
@a-poptsov you can work around this by using the `pod` or `pod_template_file` arguments for the k8sPodOperator (which should hopefully be less of a dirty hack). Those will give you full k8s API access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #11369: Users can specify sub-secrets and paths k8spodop
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #11369:
URL: https://github.com/apache/airflow/pull/11369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org