You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/15 11:24:45 UTC
[GitHub] [iceberg] jaceklaskowski opened a new pull request, #6433: Docs: README
jaceklaskowski opened a new pull request, #6433:
URL: https://github.com/apache/iceberg/pull/6433
Found some very minor "issues" while reading README.md and couldn't resist fixing them all up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6433: Docs: README
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on code in PR #6433:
URL: https://github.com/apache/iceberg/pull/6433#discussion_r1053432158
##########
README.md:
##########
@@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation.
The core Java library that tracks table snapshots and metadata is complete, but still evolving. Current work is focused on adding row-level deletes and upserts, and integration work with new engines like Flink and Hive.
-The [Iceberg format specification][iceberg-spec] is being actively updated and is open for comment. Until the specification is complete and released, it carries no compatibility guarantees. The spec is currently evolving as the Java reference implementation changes.
+The [Iceberg format specification][iceberg-spec] is being actively updated (as the Java reference implementation changes) and is open for comments. Until the specification is complete and released, it carries no compatibility guarantees.
Review Comment:
"open for comment" sounded good to me. I was actually just listening to a radio show about the evolution of words in English and this is one of the most common types. We apparently love to change our verbs into nouns and vice-versa.
Tldr; I think this one was fine as it was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6433: Docs: README
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #6433:
URL: https://github.com/apache/iceberg/pull/6433#discussion_r1051058098
##########
README.md:
##########
@@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation.
The core Java library that tracks table snapshots and metadata is complete, but still evolving. Current work is focused on adding row-level deletes and upserts, and integration work with new engines like Flink and Hive.
-The [Iceberg format specification][iceberg-spec] is being actively updated and is open for comment. Until the specification is complete and released, it carries no compatibility guarantees. The spec is currently evolving as the Java reference implementation changes.
+The [Iceberg format specification][iceberg-spec] is being actively updated (as the Java reference implementation changes) and is open for comments. Until the specification is complete and released, it carries no compatibility guarantees.
Review Comment:
Probably we can say there are compatibility guarantees for V1/V2 specs now, but itd be a bigger discussion how to phrase it. So ok with this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6433: Docs: README
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on code in PR #6433:
URL: https://github.com/apache/iceberg/pull/6433#discussion_r1053432158
##########
README.md:
##########
@@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation.
The core Java library that tracks table snapshots and metadata is complete, but still evolving. Current work is focused on adding row-level deletes and upserts, and integration work with new engines like Flink and Hive.
-The [Iceberg format specification][iceberg-spec] is being actively updated and is open for comment. Until the specification is complete and released, it carries no compatibility guarantees. The spec is currently evolving as the Java reference implementation changes.
+The [Iceberg format specification][iceberg-spec] is being actively updated (as the Java reference implementation changes) and is open for comments. Until the specification is complete and released, it carries no compatibility guarantees.
Review Comment:
"open for comment" is sounded good to me. I was actually just listening to a radio show about the evolution of words in English and this is one of the most common types. We apparently love to change our verbs into nouns and vice-versa.
Tldr; I think this one was fine as it was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6433: Docs: README
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6433:
URL: https://github.com/apache/iceberg/pull/6433#discussion_r1051676679
##########
README.md:
##########
@@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation.
The core Java library that tracks table snapshots and metadata is complete, but still evolving. Current work is focused on adding row-level deletes and upserts, and integration work with new engines like Flink and Hive.
-The [Iceberg format specification][iceberg-spec] is being actively updated and is open for comment. Until the specification is complete and released, it carries no compatibility guarantees. The spec is currently evolving as the Java reference implementation changes.
+The [Iceberg format specification][iceberg-spec] is being actively updated (as the Java reference implementation changes) and is open for comments. Until the specification is complete and released, it carries no compatibility guarantees.
Review Comment:
I think it was more clear before, with the second sentence as a separate note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org