You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/05 02:03:24 UTC

[GitHub] [dolphinscheduler] seedscoder opened a new issue, #12720: [Improvement][dolphinscheduler-tools] Improvement title

seedscoder opened a new issue, #12720:
URL: https://github.com/apache/dolphinscheduler/issues/12720

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   
   When executing `org.apache.dolphinscheduler.tools.datasource.UpgradeDolphinScheduler#main` method , If it is a blank database， This method only performs initialization operations, not DS upgrade.
   - Is this inconsistent with the method semantics ?Therefore, whether it is necessary to perform updates after initialization .
   
   > This operation is similar to the following
   
   ```java
           public void run(String... args) throws Exception {
               if (dolphinSchedulerManager.schemaIsInitialized()) {
                   dolphinSchedulerManager.upgradeDolphinScheduler();
                   logger.info("upgrade DolphinScheduler finished");
               } else {
                   dolphinSchedulerManager.initDolphinScheduler();
                   dolphinSchedulerManager.upgradeDolphinScheduler();
                   logger.info("init DolphinScheduler finished");
               }
           }
   ```
   
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12720: [Improvement][dolphinscheduler-tools] Improvement title

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12720:
URL: https://github.com/apache/dolphinscheduler/issues/12720#issuecomment-1304375304

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on issue #12720: [Improvement][dolphinscheduler-tools] whether it is necessary to perform updates after initialization

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #12720:
URL: https://github.com/apache/dolphinscheduler/issues/12720#issuecomment-1304380117

   Currently, the latest table schema will be initialized during initialization. The update logic is used to upgrade from a lower version to a higher version. @seedscoder 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] seedscoder closed issue #12720: [Improvement][dolphinscheduler-tools] whether it is necessary to perform updates after initialization

Posted by GitBox <gi...@apache.org>.
seedscoder closed issue #12720: [Improvement][dolphinscheduler-tools] whether it is necessary to perform updates after initialization
URL: https://github.com/apache/dolphinscheduler/issues/12720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org