You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GOMEZ Henri <hg...@slib.fr> on 2001/06/08 23:51:52 UTC

AJP14 - header

What about using the same header for both side in
AJP14 ?

In AJP13, we're using 0x1234 when web->servlet and 
'AB' when servlet->web.

Ajp14 use now 0x1235 in web->servlet side and 
'Ac' in servlet->web side.

What about using 0x1235 in both side (in Ajp14),
just to be consistent ....

-
Henri Gomez                 ___[_]____
EMAIL : hgomez@slib.fr        (. .)                     
PGP KEY : 697ECEDD    ...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-----Original Message-----
>From: GOMEZ Henri [mailto:hgomez@slib.fr]
>Sent: Friday, June 08, 2001 11:47 PM
>To: tomcat-dev@jakarta.apache.org
>Subject: RE: cvs commit:
>jakarta-tomcat-connectors/jk/java/org/apache/ajp Ajp13Packet.java
>
>
>>seguin      01/06/08 12:49:52
>>
>>  Modified:    jk/java/org/apache/ajp Ajp13Packet.java
>>  Log:
>>  [bug fix] send right header to webserver.
>>  now i'm glad i added a junit test ;-)
>>  
>>  Revision  Changes    Path
>>  1.6       +2 -2      
>>jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13Packet.java
>
>Thanks, I'm guilty here, dan't copy/paste ;)
>
>
>>  Index: Ajp13Packet.java
>>  ===================================================================
>>  RCS file: 
>>/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp1
>>3Packet.java,v
>>  retrieving revision 1.5
>>  retrieving revision 1.6
>>  diff -u -r1.5 -r1.6
>>  --- Ajp13Packet.java	2001/06/07 13:42:36	1.5
>>  +++ Ajp13Packet.java	2001/06/08 19:49:51	1.6
>>  @@ -198,8 +198,8 @@
>>       public void reset() {
>>           len = 4;
>>           pos = 4;
>>  -        buff[0] = (byte)(AJP13_WS_HEADER >> 8);
>>  -        buff[1] = (byte)(AJP13_WS_HEADER & 0xFF);
>>  +        buff[0] = (byte)(AJP13_SW_HEADER >> 8);
>>  +        buff[1] = (byte)(AJP13_SW_HEADER & 0xFF);
>>       }
>>   	
>>       /**
>>  
>>  
>>  
>>
>

Re: AJP14 - header

Posted by kevin seguin <se...@motive.com>.
i'm not exactly sure what the intention was with having different
headers for webserver->container and container->webserver.  i can only
assume it was to distinguish between the two directions.  i'm not
exactly sure what the different header values buy you either... so,
unless someone has a good reason for the headers to be different in
ajp14, then i'm ok with having one ajp14 header for all packets,
regardless of direction.

-kevin.

GOMEZ Henri wrote:
> 
> What about using the same header for both side in
> AJP14 ?
> 
> In AJP13, we're using 0x1234 when web->servlet and
> 'AB' when servlet->web.
> 
> Ajp14 use now 0x1235 in web->servlet side and
> 'Ac' in servlet->web side.
> 
> What about using 0x1235 in both side (in Ajp14),
> just to be consistent ....
> 
> -
> Henri Gomez                 ___[_]____
> EMAIL : hgomez@slib.fr        (. .)
> PGP KEY : 697ECEDD    ...oOOo..(_)..oOOo...
> PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6
> 
> >-----Original Message-----
> >From: GOMEZ Henri [mailto:hgomez@slib.fr]
> >Sent: Friday, June 08, 2001 11:47 PM
> >To: tomcat-dev@jakarta.apache.org
> >Subject: RE: cvs commit:
> >jakarta-tomcat-connectors/jk/java/org/apache/ajp Ajp13Packet.java
> >
> >
> >>seguin      01/06/08 12:49:52
> >>
> >>  Modified:    jk/java/org/apache/ajp Ajp13Packet.java
> >>  Log:
> >>  [bug fix] send right header to webserver.
> >>  now i'm glad i added a junit test ;-)
> >>
> >>  Revision  Changes    Path
> >>  1.6       +2 -2
> >>jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13Packet.java
> >
> >Thanks, I'm guilty here, dan't copy/paste ;)
> >
> >
> >>  Index: Ajp13Packet.java
> >>  ===================================================================
> >>  RCS file:
> >>/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp1
> >>3Packet.java,v
> >>  retrieving revision 1.5
> >>  retrieving revision 1.6
> >>  diff -u -r1.5 -r1.6
> >>  --- Ajp13Packet.java        2001/06/07 13:42:36     1.5
> >>  +++ Ajp13Packet.java        2001/06/08 19:49:51     1.6
> >>  @@ -198,8 +198,8 @@
> >>       public void reset() {
> >>           len = 4;
> >>           pos = 4;
> >>  -        buff[0] = (byte)(AJP13_WS_HEADER >> 8);
> >>  -        buff[1] = (byte)(AJP13_WS_HEADER & 0xFF);
> >>  +        buff[0] = (byte)(AJP13_SW_HEADER >> 8);
> >>  +        buff[1] = (byte)(AJP13_SW_HEADER & 0xFF);
> >>       }
> >>
> >>       /**
> >>
> >>
> >>
> >>
> >