[GitHub] sven-lange-last commented on a change in pull request #3731: Relax connection retry in invoker

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #3731: Relax connection retry in invoker
URL: https://github.com/apache/incubator-openwhisk/pull/3731#discussion_r194428599
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##########
 @@ -126,9 +126,8 @@ protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxRe
     } match {
       case Success(response) => response
       case Failure(t: RetryableConnectionError) if retry =>
-        val sleepTime = 10.milliseconds
+        val sleepTime = 50.milliseconds
 
 Review comment:
   @csantanapr Let me put it that way: it may be tempting to make this value configurable. I think that this setting should not be tampered with to save an invoker. This value is used in a `Thread.sleep()` which occupies the current worker thread. Increasing the value may have pretty undesired effects. We should find a reasonable value and don't change it any more.
   
   It would be much more important to replace the `Thread.sleep()` with something that frees the thread while waiting / sleeping.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services