You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/04 04:43:13 UTC
Review Request 18725: Prevent snappy and tcmalloc detection from leveldb
configuration phase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18725/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-1054
https://issues.apache.org/jira/browse/MESOS-1054
Repository: mesos-git
Description
-------
Removes the snappy and tcmalloc detection from the leveldb configuration phase.
Diffs
-----
3rdparty/leveldb.patch PRE-CREATION
Diff: https://reviews.apache.org/r/18725/diff/
Testing
-------
make check (with snappy installed)
Thanks,
Till Toenshoff
Re: Review Request 18725: Prevent snappy and tcmalloc detection from leveldb
configuration phase
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18725/#review36391
-----------------------------------------------------------
3rdparty/leveldb.patch
<https://reviews.apache.org/r/18725/#comment67328>
don't you want to try to link with it too like you did for tcmalloc below?
- Vinod Kone
On March 6, 2014, 6:44 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18725/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 6:44 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1054
> https://issues.apache.org/jira/browse/MESOS-1054
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removes the snappy and tcmalloc detection from the leveldb configuration phase.
>
>
> Diffs
> -----
>
> 3rdparty/leveldb.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18725/diff/
>
>
> Testing
> -------
>
> make check (with snappy installed)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18725: Prevent snappy and tcmalloc detection from leveldb
configuration phase
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18725/#review36404
-----------------------------------------------------------
Ship it!
Till reached out to me on IRC explaining me the patch as I misunderstood it. I'll commit it now.
- Vinod Kone
On March 6, 2014, 6:44 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18725/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 6:44 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1054
> https://issues.apache.org/jira/browse/MESOS-1054
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removes the snappy and tcmalloc detection from the leveldb configuration phase.
>
>
> Diffs
> -----
>
> 3rdparty/leveldb.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18725/diff/
>
>
> Testing
> -------
>
> make check (with snappy installed)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18725: Prevent snappy and tcmalloc detection from leveldb
configuration phase
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18725/
-----------------------------------------------------------
(Updated March 6, 2014, 6:44 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
assigning to myself @vinodkone for review.
Bugs: MESOS-1054
https://issues.apache.org/jira/browse/MESOS-1054
Repository: mesos-git
Description
-------
Removes the snappy and tcmalloc detection from the leveldb configuration phase.
Diffs
-----
3rdparty/leveldb.patch PRE-CREATION
Diff: https://reviews.apache.org/r/18725/diff/
Testing
-------
make check (with snappy installed)
Thanks,
Till Toenshoff