[jira] [Commented] (PHOENIX-6398) Returns uniform SQL dialect in calcite for the PQS

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297190#comment-17297190 ] 

Istvan Toth commented on PHOENIX-6398:
--------------------------------------

The official name is "Apache Phoenix"

However, as we use "Phoenix" in the thick client, it makes sense to use the same for the thin client.
WDYT [~elserj] ?



> Returns uniform SQL dialect in calcite for the PQS
> --------------------------------------------------
>
>                 Key: PHOENIX-6398
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6398
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: queryserver
>            Reporter: Cong Luo
>            Assignee: Cong Luo
>            Priority: Major
>             Fix For: 4.16.1
>
>
> database name in core module
> {code:java}
> @Override
> public String getDatabaseProductName() throws SQLException {
>     return "Phoenix";
> }{code}
> database name in PQS module
> {code:java}
> return DriverVersion.load(
>     Driver.class,
>     "org-apache-phoenix-remote-jdbc.properties",
>     "Phoenix Remote JDBC Driver",
>     "unknown version",
>     "Apache Phoenix",
>     "unknown version");
> {code}
> In result, Calcite could not create `SqlDialect` for PQS.
> {code:java}
> case "ORACLE":
>   return new OracleSqlDialect(c);
> case "PHOENIX":
>   return new PhoenixSqlDialect(c);
> .....{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)