You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/08/11 09:17:33 UTC
[Bug 8023] New: Lint error when using Captured tags with "uri" rule
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
Bug ID: 8023
Summary: Lint error when using Captured tags with "uri" rule
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: giovanni@paclan.it
Target Milestone: Undefined
The following rule gives a lint error with a modern Perl version.
header __GB_FROM_ADDR From:addr =~ /(?<GB_FROM_ADDR>.*)/
uri GB_STORAGE_GOOGLE_EMAIL
m|^https?://storage\.cloud\.google\.com/.{4,128}\#%{GB_FROM_ADDR}|i
The lint error is:
Aug 11 11:05:22.290 [14234] warn: Unescaped left brace in regex is passed
through in regex; marked by <-- HERE in m/(?<!\\\\)\\%\\\\{ <-- HERE
GB_FROM_ADDR\\\\}/ at (eval 4260) line 1795.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8023] Lint error when using Captured tags with "uri" rule
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.0
Severity|normal |blocker
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8023] Lint error when using Captured tags with "uri" rule
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
--- Comment #3 from Henrik Krohns <ap...@hege.li> ---
Check \%{} in test:
Committed revision 1903351.
The fix looks ok in 5.14 and 5.32... feel free to commit when happy..
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8023] Lint error when using Captured tags with "uri" rule
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Giovanni Bechis <gi...@paclan.it> ---
Sending lib/Mail/SpamAssassin/Plugin/Check.pm
Transmitting file data .done
Committing transaction...
Committed revision 1903359.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8023] Lint error when using Captured tags with "uri" rule
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache@hege.li
--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
Atleast test was bad as it didn't catch the warnings, now it should:
Sending t/regexp_named_capture.t
Transmitting file data .done
Committing transaction...
Committed revision 1903347.
Your fix seems to work, let's test few more versions... head hurts with all the
escaping stages..
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8023] Lint error when using Captured tags with "uri" rule
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8023
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #1 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 5789
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5789&action=edit
Proposed patch
Possible fix for the issue, lint errors are fixed and the rule still works.
--
You are receiving this mail because:
You are the assignee for the bug.