You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/06 06:36:05 UTC

[GitHub] [flink] javacaoyu opened a new pull request, #19369: [FLINK-27068][python][tests]test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37

javacaoyu opened a new pull request, #19369:
URL: https://github.com/apache/flink/pull/19369

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

[FLINK-27068] test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37
This PR will fix it.

## Brief change log

- Set parallelism to 1 in unit test case to avoid the deterministic introduced of order.

## Verifying this change
Passed in pytest (Local env)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on a diff in pull request #19369: [FLINK-27068][python][tests] Fix test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37

Posted by GitBox <gi...@apache.org>.

dianfu commented on code in PR #19369:
URL: https://github.com/apache/flink/pull/19369#discussion_r843607051


##########
flink-python/pyflink/datastream/tests/test_data_stream.py:
##########
@@ -1121,8 +1123,11 @@ def test_keyed_min_and_max(self):
         results = self.test_sink.get_results(False)
         expected = ['a', 'a', 'b', 'b']
         self.assert_equals_sorted(expected, results)
+        self.env.set_parallelism(original_parallelism)

Review Comment:
   I think this is not necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] javacaoyu commented on pull request #19369: [FLINK-27068][python][tests] Fix test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37

Posted by GitBox <gi...@apache.org>.

javacaoyu commented on PR #19369:
URL: https://github.com/apache/flink/pull/19369#issuecomment-1089984335

   Thanks @dianfu 
   I have already updated set parallelism to 1 for min/min_by/max/max_by/sum that operations test code both in Batch and Stream mode.
   
   > by the way, In the unit test code for the sum operator in stream mode, the degree of parallelism was previously set to 1, So in this update, there are no changes to the unit test code for the stream mode sum operator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu merged pull request #19369: [FLINK-27068][python][tests] Fix test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37

Posted by GitBox <gi...@apache.org>.

dianfu merged PR #19369:
URL: https://github.com/apache/flink/pull/19369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19369: [FLINK-27068][python][tests]test_keyed_min_and_max and test_keyed_min_by_and_max_by failed in py36,37

Posted by GitBox <gi...@apache.org>.

flinkbot commented on PR #19369:
URL: https://github.com/apache/flink/pull/19369#issuecomment-1089879455

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aacafbe020135e395d11c8a9b33136a342f6e515",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aacafbe020135e395d11c8a9b33136a342f6e515",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aacafbe020135e395d11c8a9b33136a342f6e515 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org