[GitHub] [griffin] wankunde commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep

[GitBox <gi...@apache.org>]

wankunde commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r316956799
 
 

 ##########
 File path: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/Expr2DQSteps.scala
 ##########
 @@ -32,6 +33,10 @@ trait Expr2DQSteps extends Loggable with Serializable {
 
   def getDQSteps(): Seq[DQStep]
 
+  implicit def recoredWriteStepToList(writeStep: RecordWriteStep): List[WriteStep] = writeStep :: Nil
+
+  implicit def metricsWriteStepToList(writeStep: MetricWriteStep): List[WriteStep] = writeStep :: Nil
 
 Review comment:
   @bhlx3lyx7 @guoyuepeng 
   At first , I think for a TransformStep there could be one sink or a sink list. So I add a implicit method，and the argument can be WriteStep or List[WriteStep].
   
   But now,I think for the result table or dataframe of a transformStep, there could be only one WriteStep( one sink can sink to different places  and we don't need different output logic). So  i want to chuange the interface to **Option[WriteStep]** .
   
   Is that ok ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services