[jira] [Commented] (LUCENE-6301) Deprecate Filter

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348799#comment-14348799 ] 

David Smiley commented on LUCENE-6301:
--------------------------------------

Hi Adrien.  

bq. But it should be possible to migrate it to two-phase approximations and having FilteredQuery deprecated in the meantime will help ensure no new code is using it. I don't think it should hold this issue as having filters removed from the core is already a good step towards removing filters entirely?

+1.  I think migrating it would be a separate JIRA issue to be created.  Can it still throw an exception if you use it in such a way as to iterate?  This is to prevent people from mis-using it.  Do you know of a similar scorer I can look at?

Another API change to deprecate filters is modifying the SpatialStrategy abstraction.  It has a makeQuery and makeFilter pair of methods, which are effectively the same thing except for the return type.  I think makeFilter should become deprecated now (as part of this issue).

> Deprecate Filter
> ----------------
>
>                 Key: LUCENE-6301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6301
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6301.patch
>
>
> It will still take time to completely remove Filter, but I think we should start deprecating it now to state our intention and encourage users to move to queries as soon as possible?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org