You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/01 03:04:43 UTC
[PR] Simplify MCP validation and verify runtime limits [shardingsphere]
terrymanu opened a new pull request, #39299:
URL: https://github.com/apache/shardingsphere/pull/39299
Simplify create and drop workflow state checks by comparing the
expected and actual rule state directly.
Verify that SQL execution tool descriptors remain aligned with MCP
runtime row and timeout limits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify MCP validation and verify runtime limits [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39299:
URL: https://github.com/apache/shardingsphere/pull/39299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify MCP validation and verify runtime limits [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39299:
URL: https://github.com/apache/shardingsphere/pull/39299#issuecomment-5149653918
### Result
**Review Result: Mergeable**
No blocking issues were found in the latest commit. The three create/drop state checks are logically equivalent to the previous implementation, and the descriptor limits match the runtime policy.
### Evidence
- Reviewed head: [`a81c0a49673`](https://github.com/apache/shardingsphere/commit/a81c0a4967342189bb2111c75d1bd72f42f7416d)
- Review scope: the latest commit relative to `5ccd9ab`.
- 99 relevant unit tests passed and the build succeeded.
- Root-cause, blast-radius, test/runtime, and convergence reviews were completed.
### Coverage
The complete PR file list and the latest commit’s workflow, descriptor registry, and YAML catalog paths were checked. This is a code-scope review; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org